From: Simon Marchi <simon.marchi@ericsson.com>
To: Wei-min Pan <weimin.pan@oracle.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH PR gdb/22736] [aarch64] gdb crashes on a conditional breakpoint with cast return type
Date: Tue, 29 May 2018 21:37:00 -0000 [thread overview]
Message-ID: <831b976d-cd21-bdf7-c0d3-b158c54d2c1b@ericsson.com> (raw)
In-Reply-To: <428ed785-ae74-1656-5a81-f2701b811a6f@oracle.com>
On 2018-05-29 01:11 PM, Wei-min Pan wrote:
> Since call_function_by_hand_dummy () already calls gdbarch_return_in_first_hidden_param_p() and sets
> hidden_first_param_p accordingly. Instead of passing the deault_return_type and having the target make
> the same call again , I think we should just pass hidden_first_param_p to gdbarch_push_dummy_call()?
I can't really tell, I am a bit confused by gdbarch_return_in_first_hidden_param_p vs
using_struct_return, and the fact that the AArch64 code also checks
language_pass_by_reference on the function's return value type. You are suggesting
replacing the call to language_pass_by_reference in aarch64_push_dummy_call by
the result of gdbarch_return_in_first_hidden_param_p coming from call_function_by_hand_dummy?
Is it really equivalent?
Simon
next prev parent reply other threads:[~2018-05-29 20:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 0:59 Weimin Pan
2018-05-27 3:42 ` Simon Marchi
2018-05-29 17:43 ` Wei-min Pan
2018-05-29 21:37 ` Simon Marchi [this message]
2018-05-30 0:29 ` Weimin Pan
2018-05-29 17:46 ` Pedro Alves
-- strict thread matches above, loose matches on Subject: below --
2018-03-01 17:03 Alan Hayward
2018-03-02 3:32 ` Joel Brobecker
2018-03-02 12:09 ` Alan Hayward
[not found] ` <CAH=s-PP-Xy7TrP-0zKCuA2X4A8Xgx_gHNvYewm41LPs7ZZJniA@mail.gmail.com>
2018-03-02 14:05 ` Alan Hayward
2018-03-02 15:18 ` Joel Brobecker
2018-03-05 15:57 ` Alan Hayward
2018-03-05 16:45 ` Pedro Alves
2018-03-07 11:10 ` Alan Hayward
2018-03-09 8:51 ` Joel Brobecker
2018-03-09 16:04 ` Pedro Alves
2018-03-09 16:44 ` Yao Qi
2018-03-09 19:11 ` Alan Hayward
2018-03-02 10:07 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831b976d-cd21-bdf7-c0d3-b158c54d2c1b@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox