From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126754 invoked by alias); 29 May 2018 20:41:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126733 invoked by uid 89); 29 May 2018 20:41:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*oracle.com, Hx-languages-length:895 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 20:41:41 +0000 Received: from ESESSHC012.ericsson.se (Unknown_Domain [153.88.183.54]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 20.FD.13413.20BBD0B5; Tue, 29 May 2018 22:41:38 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSHC012.ericsson.se (153.88.183.54) with Microsoft SMTP Server (TLS) id 14.3.382.0; Tue, 29 May 2018 22:41:38 +0200 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 29 May 2018 22:41:38 +0200 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Tue, 29 May 2018 22:41:37 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.220] (192.75.88.130) by BYAPR15MB2390.namprd15.prod.outlook.com (2603:10b6:a02:8c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Tue, 29 May 2018 20:41:35 +0000 Subject: Re: [PATCH PR gdb/22736] [aarch64] gdb crashes on a conditional breakpoint with cast return type To: Wei-min Pan , Simon Marchi CC: References: <1527290419-17631-1-git-send-email-weimin.pan@oracle.com> <428ed785-ae74-1656-5a81-f2701b811a6f@oracle.com> From: Simon Marchi Message-ID: <831b976d-cd21-bdf7-c0d3-b158c54d2c1b@ericsson.com> Date: Tue, 29 May 2018 21:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <428ed785-ae74-1656-5a81-f2701b811a6f@oracle.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0801CA0006.namprd08.prod.outlook.com (2603:10b6:803:29::16) To BYAPR15MB2390.namprd15.prod.outlook.com (2603:10b6:a02:8c::30) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2390; X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2390;3:cGRW6dptfWkiW31Bban/ajzTUXPXT+3830eXt2PXWvM4E2QNk1jjC0iF5qu8tRjGfURCSqWOyBZplcKO6rgRaw/qfRE82BSx1wgKHFRs4LvxYTkzCBDA8qHu234lVB7mnNlWv+ahsKb7907bXI0TaLJbgHixCJnYVmNlVmKnFo2UjpmnECrEL2io87tuZo5zeYXExHZeqaEl5A/xyNqYR+djHYezPeFlz2xJlpkqZrT5YNfayVVIGPcDH6hZA+Im;25:F9H/ml1piOzaeWY+/aQsdoq5iR0vrGBrnyR41WC+tm62oJWggfVtdLkHiVywFcDQQ2TDDOGt2UxFpZREaIkaZkVbIXjhV2oMhERoX6HdS7UvJSuWATB6aoMXjgioIkSU1SKxrf6EUx29d0oQ7kQb4oBHlJgpyUO8Bxg1RJ2C721C2Q1jwqpKhMza59V7RsoiCKkhTFtNLOTpnwBI6TyIL20w2Px04CZwG5IwUFy+M3JLlQV6WVPbC/8QygQT5/PQvyLVFVZCpn0puZ1zTTd0zsV3rdKeO8hGXcTPCdOij/cPNSdvWKRDQlqwqZqXsd4lqLaHqEryrnUMw7F6Z5oGGg==;31:bGjlN/hJgmbsS4QqiTen0J9Owd5TNpiDiYIO/oBL0qusTD9tOwxd6kVwPeezMNMivk2L9+Rz+WMSu19/HumznFOG8iAZlj6KVl9pTvA0aCdtQLf5kzG7wcMmHQiivaY4PVf4cl/DqVL+xsB8T3Q6W2Hr2mWkF9f6RNMPxhaIrg1KslkZGGv5i3I8LoQ+45FxU0v2DRw7GTOMSh05nQxib5vZKHZ01h3Awe4PKmkNmnk= X-MS-TrafficTypeDiagnostic: BYAPR15MB2390: X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2390;20:6IvrlT3rit/qxgzWkXjhYHyEhqpuOnx4V7l+tRB4rhzpsqWdwU2MBEzz5dwr8BEZAOqTeoF2wwjSebm2dOO5Zg+jDmNGFMWMPZXSMn3mIFUuCggvUSIU/IRezvgpHL9gB/md6LGO9Uh/WCrVUsaz+ayftmaxmCRDM6z6dXzfAfkrIAjk3t90H+cQjrDC/Z4quUA01TR6GOjJ6cyjRBZ+U6qexUMH/yio6Cf0pax4O76y3sItCq0JXkousLPZ1Vk3SUkYt80eYw9MttCtiSto7VDkC5tI657PjjuZFIcpGzEC3RBO4rbTuOlvDA93zC6PzSfptKg2p0vbUIjMnR8cO+SbmVxqJ158WjMlxIUw8MqV/24fGzrSdUJVxnTcO0Px0HsI1mU86aUgrBDjNnQVBtDazQD2kEjYxGcMzo0HDKJiRO+1CBDhwIOo0GDVgHNidg/SmqyhvawZfLWvZdODKmfxG2MA51CIBRIF+Zvvo7T94KMX/aP34HDkRSGxHjLm;4:x63e74Ib5mlqMjduFsfYY8+G23SgQQvH33netrnBrpd/mzwRkvnjdnzKCs+CSf/y9Frc3mh3CcDmHCwA09yftbK8tpcXqKctIvzApsv+r7yNan5DbrSE7daK02sKzjBbwTctIPzMRoB+cZ58po9yest4q0KclRsvqyA3iHXY41vlf8flW+9nlq5du/QTdF9CopkZp7B0dy8MAw9Cxmx5sRkF0PktaIjTfHAHxsUWIDWmlvmsQUurc2txUC6Ahp2EPL66/v4WuRnfgpzh55sHqQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:BYAPR15MB2390;BCL:0;PCL:0;RULEID:;SRVR:BYAPR15MB2390; X-Forefront-PRVS: 0687389FB0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(376002)(396003)(346002)(39860400002)(39380400002)(377424004)(189003)(199004)(16526019)(305945005)(6246003)(8936002)(105586002)(50466002)(25786009)(68736007)(66066001)(478600001)(6666003)(4326008)(26005)(31686004)(65806001)(110136005)(8676002)(81166006)(486006)(316002)(81156014)(53936002)(16576012)(58126008)(49976009)(36756003)(65956001)(6116002)(3846002)(97736004)(106356001)(44832011)(86362001)(64126003)(230700001)(956004)(52116002)(386003)(2616005)(53546011)(7736002)(47776003)(6486002)(2906002)(23676004)(52146003)(2486003)(5660300001)(186003)(229853002)(446003)(476003)(31696002)(11346002)(76176011)(65826007)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR15MB2390;H:[142.133.49.220];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjE1TUIyMzkwOzIzOmZyQzZzNHV0emFCYnRJN1lnVU44K3ovanYv?= =?utf-8?B?ek5lT1JHck4vd3grQWtLN1RtMnFVd2NVbWhGTVREK1UraU5OeEx5VHE3Wm1v?= =?utf-8?B?M21EYjMra2VQWXhzMXNvUDcybDE2Lzk3dy9hVDlveWk4UEt6K2kwR3NtcFhF?= =?utf-8?B?YXdZMk5aOU9HWWZadFg3Q2ZqVEEwaVlTL1F2d3FvblVINHdldUNnQVM1dWlD?= =?utf-8?B?Tm00V2lSYXBZN25OUVV6WGU5b3hLYWJGRVlUMitLWE11Z2FTTk5nNWo4OG9j?= =?utf-8?B?NEhaeUh4cHgvS1VRbGxtYUsxYnZTdXpFU2Z4b0RwWDlkamNINFAzK3NLL1dz?= =?utf-8?B?QmFud2lUZEVmZUNWMEpCZi9rcWp6VFdKS2tvOEpIMk5WaHJNV0dTRjE5RXVP?= =?utf-8?B?TnRtK3RUdy9XMWg0bzdUTW13bFdaa2ZYdjVMdzJZMlQ1ZXdQb3ptd2U2Uk9j?= =?utf-8?B?U0FHQTM4WkMzREN6ckl3TjlMd2I3TnpyTXVBNFhNL0hCZjdiOGN2Vk1qMVV1?= =?utf-8?B?MmFtVEdPeWRFb2ZyZXlRWEJSZXBXUlNIZC9sbkE2bm91Qnk5RlZFK29wRnRM?= =?utf-8?B?dGFHeVJuWksvY0M2bklTMGJyM1hkUGVpb1J4dk1mNEpibXNGTkExTjNFRTV4?= =?utf-8?B?N29xdjZMdnBFRm5GVy9VdzZZTjJzYkk5bkpZNTJxT2RRa0xYaE9YRy9Ud2J6?= =?utf-8?B?MDVOUVo3VzBFQ2c3OGxyZEVKcUpJalFwUENibTVLQ3owTExJQi9PUHFNNjlo?= =?utf-8?B?QU54OWZoNmVXRlh1NVhQWENPZytlTksvMWlpRk9EMFR5SmJ6eWh3R2xkNDNl?= =?utf-8?B?Z2NkTnVEZzJQbW1hN0lNVmkvV2RKQ2hhTWtIQTJwaXRtOWZGUzEwVFBzSkN2?= =?utf-8?B?SDI4elYyNnIrTGhGV2tJK0JiNytUTlJKWko2TFZwY3lsYzUwcWwydHZub2xk?= =?utf-8?B?NjdTMmkyZmZidytRQ0NhZnFPQ3JIMW44NVM3bkVhRXhSVHR6VjFYYTVMZmov?= =?utf-8?B?UVVsWFFiYXBkL0ZnZk1iT2JZZHVNbFBCV0E2SFZUWHF1NHYwc2FqQVBxMi91?= =?utf-8?B?THNOcnFtV3Jmd2JYYk9lRGxkbGJORU1hSEozYWd3MzlRTUgzSEtiRTBCckR3?= =?utf-8?B?WEhDSHFpSlBFTUp5Wnd6L2NxVUZqenpIczFUZ1JKbWpTaStZRFJHS3NBVlBl?= =?utf-8?B?YWljN29POFc5WW5pelBqTll0S002V0J0WkVBRExJSVRMZXd4QVlxREJ5UGpR?= =?utf-8?B?TENjRUNxQ291UUdOSlMxRmNGdXdVaVpKY0owZGJ2d3U4TFFxdnpNRVBSbFFq?= =?utf-8?B?bmMxanIrTVpETGFYbVZLMHYxWWtpSjRWZUdpRzVlZmpPYWRDNDVnL1BDTC9k?= =?utf-8?B?SzQvd05nb3RBMG5TNElDZTdLZUhEcmViK0lHYWRKYWJ4VHN1WEYwaHRqNjFE?= =?utf-8?B?SnMvZHkyS2JycUVEc3NFQVFoZTlPc2k1aU12cFlVOWRpOXhRSnZnUUw5S0ht?= =?utf-8?B?bUM2dEE4NnJwYWpPbkhjZG5DOVgvN2tuRzlTeDhVMW1rcE03aHhVY1VpK1lk?= =?utf-8?B?RnpKdGd5QXZ3d3BjdEVZWWFyazNwK0tvazhhbmV0RGdTK2N5ME9Zam01Mmxx?= =?utf-8?B?K3k3WWRnZGJEMTdmVk4xYXlhYlVwczZtNGhJSCtBdHhWai9LWENiZWQ2bkI4?= =?utf-8?B?QXpmUFNCL0tNMmlkUXkzUUZzRk0xSDY3VGh3U1JRcEk2bUxSK2UrNjYzWFFw?= =?utf-8?B?L1cvcEU3ZVVnUkdrTnQyT01FYXBib2RwU0RBK3Y1eGkvRnpINjE4bGd5di9P?= =?utf-8?B?enNQZm1FMjlaTEp1YkkzWW13VWlvRjdDU3FxWHllWTJXNXZiakxydVJEbFNk?= =?utf-8?B?NURXWWROcjNEVE5JU3o1YkJaVUJtZzV6RU1RK1pkYjVHVVpRTEdsbmhaTFFk?= =?utf-8?B?VDFubjVxUUx2Wlp5TFJEM0dkWVNBWm8rbW8zSUN6L0c4TGc0a3FwbkJmK3Mx?= =?utf-8?B?OUJnYy9KZEg0cHhKQXpkV1B1V0Z3VEYwZWt6dz09?= X-Microsoft-Antispam-Message-Info: N1n1wN+2nL7q8RDqOY1/x0oEpoX99Yd9plmiXrVInFmLxN4Wqzah+j/a+JUaIR+bGoS48dW4YFjNVDHgrvPYVYiiHqqyePBFNpgoCh7tfPJO9qbEE2n8pIiIVV6V5GkEHObcUj4bSOpGZe9GiI3Zv2l0jd2jwRhmwFI0NY+dNzYXlLwhZS+zNXAmBalh4Z/g X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2390;6:Oq2Blafxmeen7mwFHUzfuA044FgyyP18XsN1AI4EimXRaLjLfusv6ooFRHk0G5o8yPiB2snN9ubXApMTkpM4JCFtRCM78eh3KlkmnXxAsQWbTJw1TxZYnHUi3+BTetozjnwVUsu0Yppw2ceNd3ioRNqy5SVVbmrYWWSteXUH0ozXMoGep7SBOQZqd41bRpdhwVFaAcgV/KoTX9+bmyAyWPOr9h989WsZzUjFd8cGDP8oOzB8nPL8fAPGV2taUdtT0PaujMj1DuK88h73zlXVodZBDOLDUjc0YTPyIZ0dWggnHcBhWoNsPdzZSZsSJSiz0h3efqtImPkuo6tuucXNKgCmv/STX2zuDt+A+Tky43CCPqtjvG7JpjkQ7a475Bj48PJ9vOAiUaD6W8zCdB5X8EhZOc8fklfOSXJ9ay2O8bohY6BocARyBp4wwmxdGyVB4p8ek6+460nyRT0Yp/77aA==;5:UQ6zE4a7Eukt53datipOzP6Gs+NuGSFPpavE26aY0eCgosa/Vgq5LhM3ncfZHIjeNaOlH/TzDQgbpKW3nBcAt+JAgHLnB6jLejpAh1Dmq6V/DSy6FKmKLbkMCcidcc0tzk/Vi4b/SDRz9VmBwcS2GiP0qSF9mE4wv3Xun1lAK7c=;24:6/kHi8mVBddlywF7RyQeRBGU0tAWISbl6Adn3tzQkhgwiGzaVOEav3hevJ5q1MwzVRPcps6TnXHWulWzqCq1EEZ6YX0/qlw6Wv11iKC1B+s= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BYAPR15MB2390;7:gNuCY5pd0keRSATZi2BXcwY3LNjllbrku6wfSHCVAFClX/hAdPLQivorb+cC4kWnmiZvCvqv4cE3TteQH8nPMXirbfnSVyRytDixYS9hIuotyzgF1iEMclXVJ6seQsIVrLtz4Sr8pZYLe9WnWGPIlk5gsT2GAcDJZPwGO3YSuMRQzk5ateUWr4R8ZRFyK1e5YENnPy/3SzkNDsqUZs79NKkDs7kihA5JFBaIqn2sDWw31U/wlWEryZpuIFXW8mOj X-MS-Office365-Filtering-Correlation-Id: 6f188a31-867e-476d-190a-08d5c5a49250 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2018 20:41:35.7668 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f188a31-867e-476d-190a-08d5c5a49250 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2390 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00779.txt.bz2 On 2018-05-29 01:11 PM, Wei-min Pan wrote: > Since call_function_by_hand_dummy () already calls gdbarch_return_in_first_hidden_param_p() and sets > hidden_first_param_p accordingly. Instead of passing the deault_return_type and having the target make > the same call again , I think we should just pass hidden_first_param_p to gdbarch_push_dummy_call()? I can't really tell, I am a bit confused by gdbarch_return_in_first_hidden_param_p vs using_struct_return, and the fact that the AArch64 code also checks language_pass_by_reference on the function's return value type. You are suggesting replacing the call to language_pass_by_reference in aarch64_push_dummy_call by the result of gdbarch_return_in_first_hidden_param_p coming from call_function_by_hand_dummy? Is it really equivalent? Simon