From: Simon Marchi <simon.marchi@polymtl.ca>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case)
Date: Mon, 04 Mar 2019 18:06:00 -0000 [thread overview]
Message-ID: <8281f119488b6db2c0a963412f1b723f@polymtl.ca> (raw)
In-Reply-To: <20190304174924.27024-1-sergiodj@redhat.com>
On 2019-03-04 12:49, Sergio Durigan Junior wrote:
> On commit 8ecfd7bd4acd69213c06fac6de9af38299123547 ("Add parameter to
> allow enabling/disabling selftests via configure") it seems that I
> forgot to use the proper '$enable_unittest' variable when checking to
> see whether to add selftest-related objects to 'srv_regobj'. This
> causes a build failure on Aarch64 when 'development=false' (which is
> the case for the 8.3 branch) and 'enable_unittest=true'.
>
> This patch fixes the problem by using '$enable_unittest' instead of
> '$development' when performing the check. As a reminder, it's
> important to notice that '$enable_unittest's default value (i.e., when
> the option '--enable-unit-tests' is not passed to configure) is the
> same as '$development', so this patch doesn't affect the current
> build.
>
> I'd like to install this patch both on master and on the 8.3 branch.
>
> OK?
Thanks, this LGTM.
Simon
next prev parent reply other threads:[~2019-03-04 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 17:49 Sergio Durigan Junior
2019-03-04 18:06 ` Simon Marchi [this message]
2019-03-04 21:49 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8281f119488b6db2c0a963412f1b723f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox