From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32527 invoked by alias); 4 Mar 2019 18:06:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32514 invoked by uid 89); 4 Mar 2019 18:06:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*UA:Webmail, H*UA:Roundcube, H*u:Webmail, H*u:Roundcube X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 18:06:18 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x24I6CP9029719 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 4 Mar 2019 13:06:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 373D81E658; Mon, 4 Mar 2019 13:06:12 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 8A3C61E477; Mon, 4 Mar 2019 13:06:10 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 04 Mar 2019 18:06:00 -0000 From: Simon Marchi To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH] Use '$enable_unittest' instead of '$development' on gdbserver/configure.srv (for 'aarch64*-*-linux*' case) In-Reply-To: <20190304174924.27024-1-sergiodj@redhat.com> References: <20190304174924.27024-1-sergiodj@redhat.com> Message-ID: <8281f119488b6db2c0a963412f1b723f@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00041.txt.bz2 On 2019-03-04 12:49, Sergio Durigan Junior wrote: > On commit 8ecfd7bd4acd69213c06fac6de9af38299123547 ("Add parameter to > allow enabling/disabling selftests via configure") it seems that I > forgot to use the proper '$enable_unittest' variable when checking to > see whether to add selftest-related objects to 'srv_regobj'. This > causes a build failure on Aarch64 when 'development=false' (which is > the case for the 8.3 branch) and 'enable_unittest=true'. > > This patch fixes the problem by using '$enable_unittest' instead of > '$development' when performing the check. As a reminder, it's > important to notice that '$enable_unittest's default value (i.e., when > the option '--enable-unit-tests' is not passed to configure) is the > same as '$development', so this patch doesn't affect the current > build. > > I'd like to install this patch both on master and on the 8.3 branch. > > OK? Thanks, this LGTM. Simon