Re: [PATCH] [gdb] Remove unnecessary defs.h/common-defs.h includes

[Simon Marchi <simark@simark.ca>]

On 4/21/26 12:24 PM, Tom de Vries wrote:
> I asked an AI to review a patch that added a new file, and it mentioned I
> should add an include of defs.h as first include.
> 
> That used to be true, but since commit 18d2988e5da ("gdb, gdbserver,
> gdbsupport: remove includes of early headers") that's not the case anymore.
> 
> Error out when encountering a second include of defs.h, and remove a few of
> those.
> 
> While we're at it, do the same for gdbsupport/common-defs.h.
> 
> Tested by rebuilding gdb on aarch64-linux.

server.h in gdbserver is the same idea.  I see one include in
linux-microblaze-low.cc that should be removed.

I would suggest changing the error message to something clearer and more
actionable for those who might not know the backstory of these files,
perhaps:

  #  error gdb/defs.h should not be included manually

Simon