From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TuyNGG+v52kijjAAWB0awg (envelope-from ) for ; Tue, 21 Apr 2026 13:10:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776791407; bh=4Cauk8r1PRksLqD8A+C+4VOXLvlqdTcujtufc/bUHI4=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OWathmiEluJ33zowL4Tziio1Oe8N7E4/pcYUclHXm9LTmoIudXlcy/0k2EAO2Z39t N/YiX7kuuEokSEQVfWqTPVuuLYdCkyJuDAW6XQge/vJWS3ulTUbA8kaw1OttEafHDr UAB0tXjkSG3L2PInBziBJbZ3Vqpr3aQt2Xe4msps= Received: by simark.ca (Postfix, from userid 112) id 52E2C1E0C3; Tue, 21 Apr 2026 13:10:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=r8X27lFd; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C35611E093 for ; Tue, 21 Apr 2026 13:10:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3CCDA4BA9027 for ; Tue, 21 Apr 2026 17:10:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CCDA4BA9027 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=r8X27lFd Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2BF924BA23F7 for ; Tue, 21 Apr 2026 17:09:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BF924BA23F7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BF924BA23F7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776791382; cv=none; b=OIdMZCpIZTg6wFRk/kHCl8Bs7cHIddrrnncKiNCkr+T4ADkJn8Q6jHbTL5Ft5ITAGqkA8eOdwzYgyVwiPLpzSfvbws0TEFsKHYRkxGI+zUNPvrGFjIQTAlYEKuIh74oSXs8WNE+uHEA5LlDOElEbAp1pKOWoC7aAdDIB3U/FiZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776791382; c=relaxed/simple; bh=4Cauk8r1PRksLqD8A+C+4VOXLvlqdTcujtufc/bUHI4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Qa+P5K4aCx59arHDXuUM2bP/nNcSLIuNx+N4wY/9zVPdXrz1nBqCyYRnBZsvs2tEABwdEkX2XyJGHOAJHVTaOTME0eylxxOCL21MjHr/O/wAuur3k7ktQ4wfy4/iwCJdBphCubktcdJMKC6OF2EjrddnGr3ZLI3P/lltlnnKIV8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2BF924BA23F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776791380; bh=4Cauk8r1PRksLqD8A+C+4VOXLvlqdTcujtufc/bUHI4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=r8X27lFd7YbCo8MTViCC4KJaU2xyT/ram7RR4yfSBY/Z4EkbCRgsr2jwErQV3iUQT Qgo2flhKEmSnDH47vwDg8TMiVo/WMotFGfEwn61ZnRJua5F3vSVKE7YexPxWu34nmM f8U5m9Ytm9Xdq0Ob8kFZliSB0WxFyRaw4Pvgj210= Received: by simark.ca (Postfix) id 497B81E093; Tue, 21 Apr 2026 13:09:40 -0400 (EDT) Message-ID: <80feb4e3-b105-4fd2-8d19-d59073602f00@simark.ca> Date: Tue, 21 Apr 2026 13:09:39 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb] Remove unnecessary defs.h/common-defs.h includes To: Tom de Vries , gdb-patches@sourceware.org References: <20260421162454.1720072-1-tdevries@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <20260421162454.1720072-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/21/26 12:24 PM, Tom de Vries wrote: > I asked an AI to review a patch that added a new file, and it mentioned I > should add an include of defs.h as first include. > > That used to be true, but since commit 18d2988e5da ("gdb, gdbserver, > gdbsupport: remove includes of early headers") that's not the case anymore. > > Error out when encountering a second include of defs.h, and remove a few of > those. > > While we're at it, do the same for gdbsupport/common-defs.h. > > Tested by rebuilding gdb on aarch64-linux. server.h in gdbserver is the same idea. I see one include in linux-microblaze-low.cc that should be removed. I would suggest changing the error message to something clearer and more actionable for those who might not know the backstory of these files, perhaps: # error gdb/defs.h should not be included manually Simon