From: Kamil Rytarowski <n54@gmx.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat
Date: Mon, 20 Apr 2020 12:30:33 +0200 [thread overview]
Message-ID: <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> (raw)
In-Reply-To: <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com>
[-- Attachment #1.1: Type: text/plain, Size: 1550 bytes --]
Ping?
I rely on this patch with my other to be submitted code.
On 16.04.2020 23:32, Kamil Rytarowski wrote:
> On 16.04.2020 22:07, Tom Tromey wrote:
>>>>>>> ">" == Kamil Rytarowski <n54@gmx.com> writes:
>>
>>>> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in
>>>> details and want to implement follow-fork functionality differently.
>>
>
> Actually I was wrong in this detail. FreeBSD implements
> PT_SET_EVENT_MASK, but not PT_GET_PROCESS_STATE.
>
>>>> gdb/ChangeLog:
>>
>>>> * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
>>>> (remove_fork_catchpoint, post_startup_inferior)
>>>> (post_attach): Move...
>>
>> I guess these aren't used on Linux, but what about rs6000-nat.c? Those
>> are the only non-BSD users of inf_ptrace_target that I can see.
>>
>> I'm not a big fan of the current code, because makes methods conditional
>> on this define. It would be better I guess to have an intermediate
>> subclass for this situation. That would make it clear what code does or
>> does not rely on this.
>>
>
> Personally, I would like to see more separation of OS specific features
> into OS-private files.
>
>> You don't have to do that, but I don't think we can put this in without
>> knowing about the rs6000-nat case.
>>
>> Tom
>>
>
> IBM RS/6000 is AIX and it does not support PT_GET_PROCESS_STATE. At
> least not in the versions I could check.
>
> There was however support for PT_GET_PROCESS_STATE in HPUX, but HPUX
> handling was removed from GDB in 2015.
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-20 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 16:58 Kamil Rytarowski
2020-04-16 20:07 ` Tom Tromey
2020-04-16 21:32 ` Kamil Rytarowski
2020-04-20 10:30 ` Kamil Rytarowski [this message]
2020-04-24 9:15 ` Kamil Rytarowski
2020-04-24 15:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox