From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 9676F386F02B for ; Mon, 20 Apr 2020 10:32:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9676F386F02B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587378706; bh=DW7KuCk8Q8Q30uVDph5QnttdY945Ju/+nSrVVvEihLY=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=FXkmMQcXqQLWZmt35atbjBvI1rKWo3swoTaXK2W2ReBrRSQf0VgzldxV5K7RZ9i8h rA5NbFfDsjOFi13D65d16OvLDHgZpJvugbT+DGCsqumMP1ALO7+BLG9+9QAKQC8XK3 nNn0hDCglJDDfoX4/eaySgLpKsBFylVGxJ3zp9QY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M7Jza-1jIl0o0aZI-007pE9; Mon, 20 Apr 2020 12:31:46 +0200 Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200416165859.10785-1-n54@gmx.com> <877dyf19fw.fsf@tromey.com> <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> Date: Mon, 20 Apr 2020 12:30:33 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LlSt60Ijl7lL2iU7V7mX7Ijy9H0s4Qm5K" X-Provags-ID: V03:K1:2IWZfTTFq9szgEXjR5/Zcs+CnRrE16Hxpzqfhq5dvXC0shZs6CJ em60dAAJIfV6uoFk97y2l4mcvgFoAY7xeObKLGvrYaZvWuE5JOPtYpEhc4MKczZotpKoF7W sLxao2FDoxVZ5jHzMQtVr6Rdh+/+hQvZYmbf4DHJHUUVMmo/gEx39Y9UGmiqfNs4P2FRjlv sKGvZm380gfKVLf0psmjQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:SJL1vCuONbU=:0YlGumZgbdg8wRYHtgs4mU wA/kW0EC74bQfzCgFM3An2pjPRejBAePZ+9BV6PToYZ5LyvYQvv+xutbIOzRzqg4ntCaDJFIa db25VX4+8d1Ga+YUwMjzXjj0Bgyan74BkTckyrI8CfUVT2ZUPf4fHZL8Va30+lJI23JV72jpK vt7oja0YBax6mzUmuaCgiz/cvMUrPM/fEVr2kLN0tUG46p0IdCW2nuIGZvk1ZTz1kCKNJH+3n iarvmgqHk+xz7Wzyl8rHF+ZYmo488d9Jc3u0GYUPNgwFcuK+roZhncYOTIcryMaI9LJoOqVZo hddzRldsPOS2EG22zuNnk1WwBcAj/0gyVBAfL25UIGA9Ici2q/yhqRId5s8t37O2uAy9KuXuG VHDFlqGi2n6px25pxxHER3Fh8zP1siQQ8ktbXb/ce4OLrA77P5BunHZDhljE8UdZi+bUZ3NHs XSljUeIrkdUQ1FKUDf/b0prR9n5p6adoGti/CpBQ03PuoDAkmF5wtjU7d4CqIzdJyGALQsxjG wslSfLYwgRpGYplzIGE7LVDGcdoIk77fo8qJTGF1jlNYk6inqMuQOlenHdXntFpCqoA62m56N Kn2FQc9YARY5RsCMClA3EbYUNLDXQQs9+vgeP33y/T3sSpnVGb88BAqWZ+0G4G0KFB+mDiENf YcOFA+0Dx3OFJCEgmmwAQgknPXO/Nr+i40B05Lv4VYIsLn4Jg1uYvRQVQpScXLxK4iyzNE/iR ebmgCLClrY2+eLcTLFvI9gtNy35GBQsblzPJ92jfreBK4wEMsG4NBBY8Hr0FXoBaOiyDhawJc YoLCxt5MPvY7sQRPTRj1sR0pyCTvCql6sRBBaaBq0pjeziOA+Iu5evp+Zpsl83cex8Yx1Ma+/ hZhEumq4WtClaPMKT4uE3F7txzebbDkq0+hGwG+KN+gJFjacm8RfZy90KLUNm98JNLBRfIDdg jE3tmgkEArxTnfG+9KFinIdqSh9oBFeyZWUvzr/WcsaGLqcH7y/1HvM1ErttoxNFZAljUXskL K/B5uDRdDgZz3C82K7mW5BI5WAA7sh3k3Otq0Q0llwsyEvm4c9kw1tzMqhynLrnxMl24nJ0iz DkQKsoJUiCOfe04rg9vI6JF5jLXSbFAbki3Vd+OXNRkMTqQ4tfGS2SZWKip3lex5A7nP9ZLpO yEcj+mMY5ZoNNc3TG5fHxSivBvEZnom8NA8nfiX9Y2zhUfgjkXatkel0k9Aa62Ocp7AdA= X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 10:32:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LlSt60Ijl7lL2iU7V7mX7Ijy9H0s4Qm5K Content-Type: multipart/mixed; boundary="Cv0HBbkkXhNaOV9xPn62EmC969h3CGuZx"; protected-headers="v1" From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org Message-ID: <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat References: <20200416165859.10785-1-n54@gmx.com> <877dyf19fw.fsf@tromey.com> <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> In-Reply-To: <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> --Cv0HBbkkXhNaOV9xPn62EmC969h3CGuZx Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Ping? I rely on this patch with my other to be submitted code. On 16.04.2020 23:32, Kamil Rytarowski wrote: > On 16.04.2020 22:07, Tom Tromey wrote: >>>>>>> ">" =3D=3D Kamil Rytarowski writes: >> >>>> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in >>>> details and want to implement follow-fork functionality differently.= >> >=20 > Actually I was wrong in this detail. FreeBSD implements > PT_SET_EVENT_MASK, but not PT_GET_PROCESS_STATE. >=20 >>>> gdb/ChangeLog: >> >>>> * inf-ptrace.h (follow_fork, insert_fork_catchpoint) >>>> (remove_fork_catchpoint, post_startup_inferior) >>>> (post_attach): Move... >> >> I guess these aren't used on Linux, but what about rs6000-nat.c? Thos= e >> are the only non-BSD users of inf_ptrace_target that I can see. >> >> I'm not a big fan of the current code, because makes methods condition= al >> on this define. It would be better I guess to have an intermediate >> subclass for this situation. That would make it clear what code does = or >> does not rely on this. >> >=20 > Personally, I would like to see more separation of OS specific features= > into OS-private files. >=20 >> You don't have to do that, but I don't think we can put this in withou= t >> knowing about the rs6000-nat case. >> >> Tom >> >=20 > IBM RS/6000 is AIX and it does not support PT_GET_PROCESS_STATE. At > least not in the versions I could check. >=20 > There was however support for PT_GET_PROCESS_STATE in HPUX, but HPUX > handling was removed from GDB in 2015. >=20 --Cv0HBbkkXhNaOV9xPn62EmC969h3CGuZx-- --LlSt60Ijl7lL2iU7V7mX7Ijy9H0s4Qm5K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl6decoACgkQS7MI6bAu dmx6qg/+N+R2stI5+xpY2/xSfKDMA/di8/PEBmucRcczyWm5qxH68AF6FKX6sFtB w3C/0ObHMQcOyJREYGgw2T/JU04OzX1+aFzJm55UKIlvAoWVdCTlrE2NCQW+C3Zr gd9qJ9kuMXJRDeag8B4+D5w9md0jeXxztSV/2jJICqcGoM/+XIfGVbL6+lbeuKIs KRI5QCU1lBVUmUEMJ1HIOCZf4C3glRF94bpuZ8XoRzXjxvG52U6wc+k+bCOGfJhg QBHm/qjg4KSQzJBrUIP0yEPNlsWFHYH5OVKuhjCJTLZD149jPbeXSz8iYiRZNg2U T8rcJLsxTlgn8VufZG5bEWAdjm6YieQJU9EaSjF/BUWA9A/keRwbbLgQJ5dNKvRV geHg781spQotaK0YPLRs+K/NavNCuyPKnEgIDM+Lwqa2VfTVBahdoJZquOm+ZvTJ CjsRwDtluy+vjB4+0PnZZPZQ0LF9d/o3EwkvXkE4QzaYDEY8Z6FHT+k54rPTFRlv SOr5YC+zQ7qXB7XqSqQH5xWTc0x6F/B6ixo3hZNaeJN97DyJRtIOm9ur567wogW8 8hCXSp57v9l/gxn0j8hvMUHobP5yR/95RW+41YHp+yziy0lWb8IyS1jEqzNVltdp qyvxWGi0HWENvYNnUpekcI+5nqg8O//9dSrIOeEJoiM20vrl++A= =VRLM -----END PGP SIGNATURE----- --LlSt60Ijl7lL2iU7V7mX7Ijy9H0s4Qm5K--