From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][PATCH][symtab] Warn about unresolved DW_AT_upper_bound/DW_AT_count
Date: Thu, 26 Jul 2018 08:40:00 -0000 [thread overview]
Message-ID: <804c54ab-43e9-4249-3033-9e199ec30fd1@suse.de> (raw)
In-Reply-To: <87effr16xh.fsf@tromey.com>
On 07/25/2018 08:55 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> 2018-07-18 Tom de Vries <tdevries@suse.de>
>
> Tom> * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
> Tom> DW_AT_count can't be translated to a dynamic prop.
>
> This part is fine.
>
> Tom> * gdb.dwarf2/dw2-unresolved-ub.exp: new file.
>
> It's great to test the warning, but I think this approach is mostly
> testing whether gcc has a particular bug. The more future-proof way to
> do this sort of test would be to use the DWARF assembler to craft a bit
> of DWARF that has the problem.
I see, I'll keep that in mind. For now, I've committed without the
test-case.
Thanks,
- Tom
prev parent reply other threads:[~2018-07-26 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 17:18 Tom de Vries
2018-07-19 14:40 ` Tom Tromey
2018-07-20 21:21 ` Tom de Vries
2018-07-25 18:55 ` Tom Tromey
2018-07-26 8:40 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804c54ab-43e9-4249-3033-9e199ec30fd1@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox