From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61508 invoked by alias); 26 Jul 2018 08:40:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61473 invoked by uid 89); 26 Jul 2018 08:40:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jul 2018 08:40:00 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 77E49AD4D; Thu, 26 Jul 2018 08:39:58 +0000 (UTC) Subject: Re: [RFC][PATCH][symtab] Warn about unresolved DW_AT_upper_bound/DW_AT_count To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20180718171814.br2yfrfajkyk6i2j@delia> <87a7qni90r.fsf@tromey.com> <20180720212155.b4aawf5pjqokxnon@delia> <87effr16xh.fsf@tromey.com> From: Tom de Vries Message-ID: <804c54ab-43e9-4249-3033-9e199ec30fd1@suse.de> Date: Thu, 26 Jul 2018 08:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87effr16xh.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00721.txt.bz2 On 07/25/2018 08:55 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> 2018-07-18 Tom de Vries > > Tom> * dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or > Tom> DW_AT_count can't be translated to a dynamic prop. > > This part is fine. > > Tom> * gdb.dwarf2/dw2-unresolved-ub.exp: new file. > > It's great to test the warning, but I think this approach is mostly > testing whether gcc has a particular bug. The more future-proof way to > do this sort of test would be to use the DWARF assembler to craft a bit > of DWARF that has the problem. I see, I'll keep that in mind. For now, I've committed without the test-case. Thanks, - Tom