Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: Simon Marchi <simark@simark.ca>,
	Christian Biesinger	<cbiesinger@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch, testsuite] Fixes for gdb.python tests on remote Windows host
Date: Tue, 13 Aug 2019 16:32:00 -0000	[thread overview]
Message-ID: <7fc029cc-d738-e5f9-9601-c230d957fd06@codesourcery.com> (raw)
In-Reply-To: <7299592f-829a-b8e8-a257-c2a0d4eee9df@simark.ca>

On 8/12/19 8:54 PM, Simon Marchi wrote:
> On 2019-08-12 10:18 p.m., Sandra Loosemore wrote:
>> I believe they are completely separate targets.  I don't know much about
>> cygwin, but I assume that Python built for cygwin library is linked with
>> the cygwin C library and understands cygwin's fake symbolic links, while
>> Python built for the mingw C library certainly does not.  Similarly,
>> using ";" instead of ":" in PATH-like things is a Windows thing, while
>> I'm pretty sure cygwin emulates the POSIX syntax.
> 
> Indeed, testing on cygwin would be a whole other task.
> 
> I forgot to mention, the patch LGTM, so if Christian is fine with this response too, then please push.

Thanks for the speedy review!  I fixed the indentation problem you noted 
before pushing the patch.

BTW, these are not the only issues I noticed in running the Python tests 
on Windows host.  There's another set involving the "explore" command 
and the python interactive help which fail with timeouts because the 
expected output is getting buffered.  At this point I'm not sure whether 
this is a problem with our test environment (we use cygwin ssh, which 
native Windows doesn't recognize as a tty), or some misconfiguration in 
the version of Windows python we are using.  I've got a local patch to 
temporarily disable those tests to speed up testing, but I don't think 
that's a good fix for mainline.  It would be better to figure out how to 
force Python to unbuffer the output.

-Sandra


  parent reply	other threads:[~2019-08-13 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 22:20 Sandra Loosemore
2019-08-13  1:35 ` Christian Biesinger via gdb-patches
2019-08-13  2:18   ` Sandra Loosemore
2019-08-13  2:54     ` Simon Marchi
2019-08-13  3:01       ` Christian Biesinger via gdb-patches
2019-08-13 16:32       ` Sandra Loosemore [this message]
2019-08-13  1:46 ` Simon Marchi
2019-08-13  2:31   ` Sandra Loosemore
2019-08-13  2:39     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fc029cc-d738-e5f9-9601-c230d957fd06@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox