From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113437 invoked by alias); 13 Aug 2019 16:32:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113422 invoked by uid 89); 13 Aug 2019 16:32:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=explore X-HELO: esa2.mentor.iphmx.com Received: from esa2.mentor.iphmx.com (HELO esa2.mentor.iphmx.com) (68.232.141.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Aug 2019 16:32:06 +0000 IronPort-SDR: nN3UIW4QwAdkN27zLgcIvoaoU8V/gPp3a8t3oNRRJqBWSv4EOATJRZwf2cNNGQb5X08vACb+5u r5A/VbC6mzbuY6SKeAevlPN17s8u6qHDbUhxbjN7moYxpkkyqGd7esWkzBzxFHLQl0R2+jL8m1 MMYRbW9PWPzcsXUKyg4TooyS285nvFKRBFl6UWX+pGwuSXIatpm97Tn/EinRL40LiBM4tvT3ng Agf1dJzYg0Qzp8sWeBhcI6YPmzPJ4gK6MAFoc23zNtZkZwkDYAE6u/lzMKL4cnlkWoommUrCeQ DdY= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 13 Aug 2019 08:32:04 -0800 IronPort-SDR: uZ9zkCU57Ev3Qx12BLTTCcLlik/WkPFcGo3qyuZNxCJeqFL2jRPapK0SuNAJgjjeJOWYuwgpwr 7h/RjZMU1Hriql3tiW8Zua/ZTsJm/y6mfWdj083d2AbdxjF1RxezDOs5LOvPPxfVjFgswCOUXO vuSv/3RH56Ye8VfPnQ6AKF6c/kPUOQd2vo912UP1oyufLuaG1Oj5ORJVQkXniREGInD0KSUyNF uUFsozgpNiC9G6wPiV6QS4mDWR4AEknfzVNf+yBiq+oVkG/ivDRPqkEtkQq9bmtKzU5j1RCWZW NK0= Subject: Re: [patch, testsuite] Fixes for gdb.python tests on remote Windows host To: Simon Marchi , Christian Biesinger CC: "gdb-patches@sourceware.org" References: <59beb385-aec5-13b8-6095-3c7eb18f94be@codesourcery.com> <876b1691-f90a-5944-3c7e-d756fc2114ce@codesourcery.com> <7299592f-829a-b8e8-a257-c2a0d4eee9df@simark.ca> From: Sandra Loosemore Message-ID: <7fc029cc-d738-e5f9-9601-c230d957fd06@codesourcery.com> Date: Tue, 13 Aug 2019 16:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <7299592f-829a-b8e8-a257-c2a0d4eee9df@simark.ca> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: sandra@codesourcery.com X-SW-Source: 2019-08/txt/msg00271.txt.bz2 On 8/12/19 8:54 PM, Simon Marchi wrote: > On 2019-08-12 10:18 p.m., Sandra Loosemore wrote: >> I believe they are completely separate targets. I don't know much about >> cygwin, but I assume that Python built for cygwin library is linked with >> the cygwin C library and understands cygwin's fake symbolic links, while >> Python built for the mingw C library certainly does not. Similarly, >> using ";" instead of ":" in PATH-like things is a Windows thing, while >> I'm pretty sure cygwin emulates the POSIX syntax. > > Indeed, testing on cygwin would be a whole other task. > > I forgot to mention, the patch LGTM, so if Christian is fine with this response too, then please push. Thanks for the speedy review! I fixed the indentation problem you noted before pushing the patch. BTW, these are not the only issues I noticed in running the Python tests on Windows host. There's another set involving the "explore" command and the python interactive help which fail with timeouts because the expected output is getting buffered. At this point I'm not sure whether this is a problem with our test environment (we use cygwin ssh, which native Windows doesn't recognize as a tty), or some misconfiguration in the version of Windows python we are using. I've got a local patch to temporarily disable those tests to speed up testing, but I don't think that's a good fix for mainline. It would be better to figure out how to force Python to unbuffer the output. -Sandra