Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Correctly handle L'\\'
Date: Mon, 7 Jul 2025 22:04:07 +0200	[thread overview]
Message-ID: <7fa1e859-6a78-45f9-8668-7b86fe2eda91@suse.de> (raw)
In-Reply-To: <e7574afb-5bcb-46f6-bed1-1d387845462b@suse.de>

On 7/5/25 07:55, Tom de Vries wrote:
> On 7/3/25 20:55, Tom Tromey wrote:
>> +gdb_test "print L'\\\\'" " = $decimal L'\\\\\\\\'"
> 
> Hi Tom,
> 
> thanks for fixing this.
> 
> Please use this more readable and maintainable style:
> ...
> +set wbs {L'\\'}
> +gdb_test "print $wbs" " = $decimal [string_to_regexp $wbs]"
> ...
 >

Hi Tom,

I see you used:
...
+set result [string_to_regexp {L'\\'}]
+gdb_test "print L'\\\\'" " = $decimal $result"
...
in your commit.

Is there any reason why you kept L'\\\\' ?

Thanks,
- Tom

> Other than that, LGTM.
> 
> Reviewed-By: Tom de Vries <tdevries@suse.de>
> 
> Thanks,
> - Tom


  reply	other threads:[~2025-07-07 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 18:55 Tom Tromey
2025-07-04 18:27 ` Hannes Domani
2025-07-05  5:55 ` Tom de Vries
2025-07-07 20:04   ` Tom de Vries [this message]
2025-07-07 20:30     ` Tom Tromey
2025-07-08 14:58       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fa1e859-6a78-45f9-8668-7b86fe2eda91@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox