From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u9d9OlQobGgdHS4AWB0awg (envelope-from ) for ; Mon, 07 Jul 2025 16:04:36 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yIJS64Pn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9d6fY6fV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yIJS64Pn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9d6fY6fV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DF2591E11C; Mon, 7 Jul 2025 16:04:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 332471E0C2 for ; Mon, 7 Jul 2025 16:04:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B1668385AC1E for ; Mon, 7 Jul 2025 20:04:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1668385AC1E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yIJS64Pn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9d6fY6fV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yIJS64Pn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9d6fY6fV Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 43D833857823 for ; Mon, 7 Jul 2025 20:04:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D833857823 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43D833857823 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751918645; cv=none; b=Is6XToZWAXliWMw/3MCRsnN5lbuvPB5kPzE02YQJdIHJsqpBVfnTx++a9vZ+zRiREklB04l4mLvQHgkzefhr7OhOZ1RRGuZ+RAfas84hpL44UKSKAaPVlRQ7KIF0AjF8l9LM2XIDea4tmEn5fMViKyPE+U3jpKJQHVxIEQXEW+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751918645; c=relaxed/simple; bh=Vy4zKHX6hOboTHW3iF0Cvo/b1Xt6kMfdfcAFAJPiT60=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=vZ9gP3Ix45alUV+sDHB8amAYnXhvsc/DAnpsfu5v7l7rV6RVHkPEwtATu/eqVEpTOCu1mag5qzW8CTgyrwPyQok7pgPOvg5p4AOYEzYJyd/8YVw5QWVhT5jneZkU9PBO8GBfEV7MoNa6YBe2oPj1oE9DJJplswnoKjLURnq4IGw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43D833857823 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0949E21166; Mon, 7 Jul 2025 20:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751918644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY+r1w0HVTeJWx88Y2iZvKUm25taSohU+GoZma3aAW4=; b=yIJS64PnHtMSHSSpaPvuelrLtZ+hsAPGOG4HgSpu9urguV+4tQGKVwA2vNq8IuAnwTxj5h 0ye8V5q4g1/TVUiRQsnH8Uq1GhvOVurYdMDGcc5D6wyJd72MnGYPDP5a3zzgDB7IF6/Yu3 YqzBTYw578bH8/mLTI0HM1j153NHwOM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751918644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY+r1w0HVTeJWx88Y2iZvKUm25taSohU+GoZma3aAW4=; b=9d6fY6fVONC9UDPG8itB/HvPXdua0UIuZdBl2LPLkWpWQzEXVUyqxuBGQ6mmq48dO3O1bs X9seJoHMVMLqksDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751918644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY+r1w0HVTeJWx88Y2iZvKUm25taSohU+GoZma3aAW4=; b=yIJS64PnHtMSHSSpaPvuelrLtZ+hsAPGOG4HgSpu9urguV+4tQGKVwA2vNq8IuAnwTxj5h 0ye8V5q4g1/TVUiRQsnH8Uq1GhvOVurYdMDGcc5D6wyJd72MnGYPDP5a3zzgDB7IF6/Yu3 YqzBTYw578bH8/mLTI0HM1j153NHwOM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751918644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KY+r1w0HVTeJWx88Y2iZvKUm25taSohU+GoZma3aAW4=; b=9d6fY6fVONC9UDPG8itB/HvPXdua0UIuZdBl2LPLkWpWQzEXVUyqxuBGQ6mmq48dO3O1bs X9seJoHMVMLqksDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E213B13A5E; Mon, 7 Jul 2025 20:04:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id egNJNTMobGjGFAAAD6G6ig (envelope-from ); Mon, 07 Jul 2025 20:04:03 +0000 Message-ID: <7fa1e859-6a78-45f9-8668-7b86fe2eda91@suse.de> Date: Mon, 7 Jul 2025 22:04:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Correctly handle L'\\' From: Tom de Vries To: Tom Tromey , gdb-patches@sourceware.org References: <20250703185525.1309719-1-tromey@adacore.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:email, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/5/25 07:55, Tom de Vries wrote: > On 7/3/25 20:55, Tom Tromey wrote: >> +gdb_test "print L'\\\\'" " = $decimal L'\\\\\\\\'" > > Hi Tom, > > thanks for fixing this. > > Please use this more readable and maintainable style: > ... > +set wbs {L'\\'} > +gdb_test "print $wbs" " = $decimal [string_to_regexp $wbs]" > ... > Hi Tom, I see you used: ... +set result [string_to_regexp {L'\\'}] +gdb_test "print L'\\\\'" " = $decimal $result" ... in your commit. Is there any reason why you kept L'\\\\' ? Thanks, - Tom > Other than that, LGTM. > > Reviewed-By: Tom de Vries > > Thanks, > - Tom