From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Change search_symbols to return std::vector
Date: Mon, 09 Oct 2017 01:52:00 -0000 [thread overview]
Message-ID: <7f661adb-6922-820e-0bef-91df1e3ad15b@simark.ca> (raw)
In-Reply-To: <20171008225201.21755-1-tom@tromey.com>
On 2017-10-08 06:52 PM, Tom Tromey wrote:
> This changes search_symbols to return a std::vector, replacing the
> previous linked list approach. This allows the removal of some
> cleanups, as well as the use of std::sort and std::unique, saving some
> code and extra allocations in sort_search_symbols_remove_dups.
>
> Regression tested by the buildbot.
LGTM. I made a patch almost identical to this one some time ago, but then got
sidetracked trying to understand the logic of search_symbols, and then forgot
to submit it...
prev parent reply other threads:[~2017-10-09 1:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 22:52 Tom Tromey
2017-10-09 1:52 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f661adb-6922-820e-0bef-91df1e3ad15b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox