From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-142370-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 95540 invoked by alias); 9 Oct 2017 01:52:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 95531 invoked by uid 89); 9 Oct 2017 01:52:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Oct 2017 01:52:44 +0000
Received: from [10.0.0.11] (cable-192.222.251.162.electronicbox.net [192.222.251.162])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id D62061E515;	Sun,  8 Oct 2017 21:52:42 -0400 (EDT)
Subject: Re: [RFA] Change search_symbols to return std::vector
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20171008225201.21755-1-tom@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <7f661adb-6922-820e-0bef-91df1e3ad15b@simark.ca>
Date: Mon, 09 Oct 2017 01:52:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171008225201.21755-1-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-10/txt/msg00177.txt.bz2

On 2017-10-08 06:52 PM, Tom Tromey wrote:
> This changes search_symbols to return a std::vector, replacing the
> previous linked list approach.  This allows the removal of some
> cleanups, as well as the use of std::sort and std::unique, saving some
> code and extra allocations in sort_search_symbols_remove_dups.
> 
> Regression tested by the buildbot.

LGTM.  I made a patch almost identical to this one some time ago, but then got
sidetracked trying to understand the logic of search_symbols, and then forgot
to submit it...