Re: [PATCH 1/3] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error

[Pedro Alves <palves@redhat.com>]

On 05/04/2018 07:30 PM, Joel Brobecker wrote:
> Trying to start GDBserver on Windows currently yields the following
> error...
> 
>     $ gdbserver.exe --once :4444 simple_main.exe
>     glob could not process pattern '(null)'.
>     Exiting
> 
> ... after which GDB terminates with a nonzero status.
> 
> This is because create_process in win32-low.c calls gdb_tilde_expand
> with the result of a call to get_inferior_cwd without verifying that
> the returned directory is not NULL:
> 
>     | static BOOL
>     | create_process (const char *program, char *args,
>     |                 DWORD flags, PROCESS_INFORMATION *pi)
>     | {
>     |   const char *inferior_cwd = get_inferior_cwd ();
>     |   std::string expanded_infcwd = gdb_tilde_expand (inferior_cwd);
> 
> This patch avoids this by only calling gdb_tilde_expand when
> INFERIOR_CWD is not NULL, which is similar to what is done on
> GNU/Linux for instance.
> 
> gdb/gdbserver/ChangeLog:
> 
> 	* win32-low.c (create_process): Only call gdb_tilde_expand if
> 	inferior_cwd is not NULL.
LGTM.

Thanks,
Pedro Alves