Re: [PATCH v2] configure: Support --with-zstd=PATH

[Simon Marchi <simark@simark.ca>]

On 2026-09-28 01:30, Torbjörn SVENSSON wrote:
> Hi,
> 
> V1 can be found here:
> https://sourceware.org/pipermail/binutils/2026-September/151687.html
> 
> Changes since v1:
> - Added missed changes in binutils/Makefile.am and binutils/Makefile.in
> - Added support for dynamic version of zstd in path
> 
> 
> Ok for trunk?
> 
> Kind regards,
> Torbjörn
> 
> --
> 
> Allow --with-zstd to specify an installation prefix.  Use the headers
> and static library under that prefix, and reject it if it does not
> provide zstd 1.4.0 or newer.
> 
> Regenerate the affected configure scripts.
> 
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>

Can you explain why using pkg-config wouldn't work for your use case?

In your other message, you mentioned that gcc also accepted a
--with-zstd=path, but it actually accepts more:

  --with-zstd=PATH        specify prefix directory for installed zstd library.
                          Equivalent to --with-zstd-include=PATH/include plus
                          --with-zstd-lib=PATH/lib
  --with-zstd-include=PATH
                          specify directory for installed zstd include files
  --with-zstd-lib=PATH    specify directory for the installed zstd library

This is open-coded in gcc/configure.ac:

  # Look for the ZSTD package.
  ZSTD_INCLUDE=
  ZSTD_LIB=
  AC_SUBST(ZSTD_INCLUDE)
  AC_SUBST(ZSTD_LIB)
  ZSTD_CPPFLAGS=
  ZSTD_LDFLAGS=
  AC_SUBST(ZSTD_CPPFLAGS)
  AC_SUBST(ZSTD_LDFLAGS)
  AC_ARG_WITH(zstd,
          [AS_HELP_STRING([--with-zstd=PATH],
                  [specify prefix directory for installed zstd library.
                   Equivalent to --with-zstd-include=PATH/include
                   plus --with-zstd-lib=PATH/lib])])
  AC_ARG_WITH(zstd-include,
          [AS_HELP_STRING([--with-zstd-include=PATH],
                  [specify directory for installed zstd include files])])
  AC_ARG_WITH(zstd-lib,
          [AS_HELP_STRING([--with-zstd-lib=PATH],
                  [specify directory for the installed zstd library])])

For consistency across the toolchain, would you consider moving this gcc
code to gcc/config/zstd.m4, and then sync gcc's zstd.m4 over to
binutils-gdb?

Simon