From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NhntEy0cu2p/7BQAWB0awg (envelope-from ) for ; Mon, 28 Sep 2026 22:02:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1790647341; bh=UdSsM/dxMYPO1Ut4OQ5yTW1BLR/TYmfuUDtufBqSM/A=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WXFVSu7ePvCIt0VKQvZ88IIU7KZlZjtaQ/ODPRgtYi/rmr2QI6nqxjDz2SJ/17Q8E lg7ovU0+elBQnYeRxpDsSvYGlzYIAfUX6O+rt6T1Rb2AanQqANpe5qqp25MffMgONx uWW/LhJWuMhO/ZHBoZZ0Q7Nqw7qod5HWz32S5XQ0= Received: by simark.ca (Postfix, from userid 112) id 3D52C1E033; Mon, 28 Sep 2026 22:02:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Nd1VWJqY; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A9081E033 for ; Mon, 28 Sep 2026 22:02:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 494234BA900E for ; Tue, 29 Sep 2026 02:02:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 494234BA900E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Nd1VWJqY Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E8CAF4BA900E; Tue, 29 Sep 2026 02:00:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8CAF4BA900E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E8CAF4BA900E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790647239; cv=none; b=rWSGNeyZGDF2VGm5iA6Az9u3zZjz9duyXgHSGpgn/TysNaaB/1UBnghyDpxwAHiI+abcU6MX+JIA3OeOsOWjCqyesOloYyoKEIkqy0+oY2ZXF6S9HcUaS+17VQ/9I78oQsfbf5uzrADwcxUv8AL+b53M6sKkG9xDfO6G1TGyezE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790647239; c=relaxed/simple; bh=UdSsM/dxMYPO1Ut4OQ5yTW1BLR/TYmfuUDtufBqSM/A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WoStltmcjgGdwlYX2dXp47yVQiQ/f/I1XNhHfljlPcL4Pi1P7pM47CnhxdR69lOAGaOk058tMiXOADbLXlbNTiDLMFbB8B54BnZ16ILL3aVSkoBc6miO35buX03Qj7T7sPlQ3qZU60M2EpptOw1DFsL+wUIj6R+ivuQ9mPfonTY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Nd1VWJqY DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8CAF4BA900E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1790647237; bh=UdSsM/dxMYPO1Ut4OQ5yTW1BLR/TYmfuUDtufBqSM/A=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Nd1VWJqY5nDfkl79EETqPsI7AamoX49O/cIw9i8VBiBRQCauuGwIr2hOzQbKuwuwH kH+6os49FgiW2c2oMD14VlN9ia9pULadLE+UWnt2vI3M7gA7nLDu6/0o9ClPZIUQ1R +EjXdM0eCyPWoihFt4IV+rRDfJ0F4rZGg/5PsE98= Received: by simark.ca (Postfix) id A31FF1E033; Mon, 28 Sep 2026 22:00:32 -0400 (EDT) Message-ID: <7e7d11d7-8b43-4150-81cb-29864763f4cf@simark.ca> Date: Mon, 28 Sep 2026 22:00:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] configure: Support --with-zstd=PATH To: =?UTF-8?Q?Torbj=C3=B6rn_SVENSSON?= , binutils@sourceware.org, gdb-patches@sourceware.org References: <20260928053309.1949979-1-torbjorn.svensson@foss.st.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260928053309.1949979-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-28 01:30, Torbjörn SVENSSON wrote: > Hi, > > V1 can be found here: > https://sourceware.org/pipermail/binutils/2026-September/151687.html > > Changes since v1: > - Added missed changes in binutils/Makefile.am and binutils/Makefile.in > - Added support for dynamic version of zstd in path > > > Ok for trunk? > > Kind regards, > Torbjörn > > -- > > Allow --with-zstd to specify an installation prefix. Use the headers > and static library under that prefix, and reject it if it does not > provide zstd 1.4.0 or newer. > > Regenerate the affected configure scripts. > > Signed-off-by: Torbjörn SVENSSON Can you explain why using pkg-config wouldn't work for your use case? In your other message, you mentioned that gcc also accepted a --with-zstd=path, but it actually accepts more: --with-zstd=PATH specify prefix directory for installed zstd library. Equivalent to --with-zstd-include=PATH/include plus --with-zstd-lib=PATH/lib --with-zstd-include=PATH specify directory for installed zstd include files --with-zstd-lib=PATH specify directory for the installed zstd library This is open-coded in gcc/configure.ac: # Look for the ZSTD package. ZSTD_INCLUDE= ZSTD_LIB= AC_SUBST(ZSTD_INCLUDE) AC_SUBST(ZSTD_LIB) ZSTD_CPPFLAGS= ZSTD_LDFLAGS= AC_SUBST(ZSTD_CPPFLAGS) AC_SUBST(ZSTD_LDFLAGS) AC_ARG_WITH(zstd, [AS_HELP_STRING([--with-zstd=PATH], [specify prefix directory for installed zstd library. Equivalent to --with-zstd-include=PATH/include plus --with-zstd-lib=PATH/lib])]) AC_ARG_WITH(zstd-include, [AS_HELP_STRING([--with-zstd-include=PATH], [specify directory for installed zstd include files])]) AC_ARG_WITH(zstd-lib, [AS_HELP_STRING([--with-zstd-lib=PATH], [specify directory for the installed zstd library])]) For consistency across the toolchain, would you consider moving this gcc code to gcc/config/zstd.m4, and then sync gcc's zstd.m4 over to binutils-gdb? Simon