Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Alan Hayward <alan.hayward@arm.com>, <gdb-patches@sourceware.org>
Cc: <nd@arm.com>
Subject: Re: [PATCH v3 1/3] Split size in regset section iterators
Date: Fri, 10 Aug 2018 18:57:00 -0000	[thread overview]
Message-ID: <7dcb6b73-30cc-ee68-7234-2d0e702d6bae@ericsson.com> (raw)
In-Reply-To: <20180810160849.68985-2-alan.hayward@arm.com>

Hi Alan,

Just a nit, otherwise it LGTM.

On 2018-08-10 12:08 PM, Alan Hayward wrote:
> diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
> index 447394381e..f8e03461ae 100755
> --- a/gdb/gdbarch.sh
> +++ b/gdb/gdbarch.sh
> @@ -1316,13 +1316,15 @@ typedef int (iterate_over_objfiles_in_search_order_cb_ftype)
>  
>  /* Callback type for regset section iterators.  The callback usually
>     invokes the REGSET's supply or collect method, to which it must
> -   pass a buffer with at least the given SIZE.  SECT_NAME is a BFD
> -   section name, and HUMAN_NAME is used for diagnostic messages.
> -   CB_DATA should have been passed unchanged through the iterator.  */
> +   pass a buffer - for collects this buffer will need to created using

Missing a word?

Simon


  reply	other threads:[~2018-08-10 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10 16:09 [PATCH v3 0/3] Detect SVE when reading aarch64 core files Alan Hayward
2018-08-10 16:09 ` [PATCH v3 2/3] " Alan Hayward
2018-08-10 19:08   ` Simon Marchi
2018-08-10 16:09 ` [PATCH v3 1/3] Split size in regset section iterators Alan Hayward
2018-08-10 18:57   ` Simon Marchi [this message]
2018-08-10 16:09 ` [PATCH v3 3/3] Parse SVE registers in aarch64 core file reading/writing Alan Hayward
2018-08-10 19:25   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dcb6b73-30cc-ee68-7234-2d0e702d6bae@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox