From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43646 invoked by alias); 10 Aug 2018 18:57:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42187 invoked by uid 89); 10 Aug 2018 18:57:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=Hx-languages-length:801 X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 18:57:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1533927429; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9r+bRgA3t+C6uO/H++H9KLQd+z/hlL7fpYJpVdbjF30=; b=I+LuCvhk+M1cCaBGuJV9M8S0lhSI7teGqnBM3rXhzkVd0F39vUudZZ9N/gyfhNwZ ADyGh47SQE1F2G48Li8LACGPePbRdMSmjNyUKw7dBtJ9YqQN8iQLW6UZPfMdmb/f PFfvR8ywRsJw/Ci2sIY6gngJtswCBMcEwI9Vc2kdXuk=; Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id FE.02.05215.500ED6B5; Fri, 10 Aug 2018 20:57:09 +0200 (CEST) Received: from ESESSMB504.ericsson.se (153.88.183.192) by ESESSMB504.ericsson.se (153.88.183.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 10 Aug 2018 20:57:08 +0200 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 10 Aug 2018 20:57:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bB4ldAdOMDV8oUwxzVLouDyu4h8z5sypLe2tMFP6148=; b=PnPBmF6JyAu6Tr3y98zDFcOJ4Sk07zsjuYhpeV9LKLy77yAb9LY+cfSqsAKCZi2/KTV4Mf0XsulGnSerrzDrGnEC/I9gCe9OBbJXv+vUL7kOVzJvWJE1DaTpJg+em4HDRdnDkE2D1XKiDdwF84publoBPx6m5uyGs1FrTIYjhXw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.48] (192.75.88.130) by SN6PR15MB2398.namprd15.prod.outlook.com (52.135.65.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.23; Fri, 10 Aug 2018 18:57:05 +0000 Subject: Re: [PATCH v3 1/3] Split size in regset section iterators To: Alan Hayward , CC: References: <20180810160849.68985-1-alan.hayward@arm.com> <20180810160849.68985-2-alan.hayward@arm.com> From: Simon Marchi Message-ID: <7dcb6b73-30cc-ee68-7234-2d0e702d6bae@ericsson.com> Date: Fri, 10 Aug 2018 18:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180810160849.68985-2-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00293.txt.bz2 Hi Alan, Just a nit, otherwise it LGTM. On 2018-08-10 12:08 PM, Alan Hayward wrote: > diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh > index 447394381e..f8e03461ae 100755 > --- a/gdb/gdbarch.sh > +++ b/gdb/gdbarch.sh > @@ -1316,13 +1316,15 @@ typedef int (iterate_over_objfiles_in_search_order_cb_ftype) > > /* Callback type for regset section iterators. The callback usually > invokes the REGSET's supply or collect method, to which it must > - pass a buffer with at least the given SIZE. SECT_NAME is a BFD > - section name, and HUMAN_NAME is used for diagnostic messages. > - CB_DATA should have been passed unchanged through the iterator. */ > + pass a buffer - for collects this buffer will need to created using Missing a word? Simon