Re: [PATCH v2] C++ify gdb/common/environ.c

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2017-04-15 14:50, Sergio Durigan Junior wrote:
> As part of the preparation necessary for my upcoming task, I'd like to
> propose that we turn gdb_environ into a class.  The approach taken
> here is simple: the class gdb_environ contains everything that is
> needed to manipulate the environment variables.  These variables are
> stored in two data structures: an unordered_set, good because lookups
> are O(n), and an std::vector<char *>, which can be converted to a
> 'char **' and passed as argument to functions that need it.

Forgot to mention (probably a typo) that lookups in the map are O(1) on 
average.  If they were O(n), it wouldn't be better than looking up in a 
vector :).

At least that's what it says here:

[1] http://en.cppreference.com/w/cpp/container/unordered_map/at

Simon