From: Jiang Jilin <freephp@gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Michael Snyder <msnyder@vmware.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix off-by-one error in record.c (record_list_release_first)
Date: Tue, 13 Oct 2009 08:28:00 -0000 [thread overview]
Message-ID: <7d77a27d0910130128p4a16d0e2p25833a6e90ee4445@mail.gmail.com> (raw)
In-Reply-To: <daef60380910122346x7a0ffc10jcd7ce7f137e9028f@mail.gmail.com>
On Tue, Oct 13, 2009 at 2:46 PM, Hui Zhu <teawater@gmail.com> wrote:
> Thanks Michael and Jilin,
>
> I think the Michael's patch is more spend up. Jilin's patch is more
> clear and can handle set_record_insn_max_num.
>
> I suggest we choice speed up. Do you think it's OK?
Agree with you. :)
> If we choice it, Michael, could you please add some comments to
> "record_list_release_first" or change it's name to
> "record_list_release_first_without_update_xxx" to make it clear.
> And please update set_record_insn_max_num.
>
> Thanks,
> Hui
>
--
Jiang
next prev parent reply other threads:[~2009-10-13 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 16:39 Michael Snyder
2009-10-13 2:17 ` Jiang Jilin
2009-10-13 6:46 ` Hui Zhu
2009-10-13 8:28 ` Jiang Jilin [this message]
2009-10-13 18:06 ` Michael Snyder
2009-10-15 3:18 ` Hui Zhu
2009-10-15 16:53 ` Michael Snyder
2009-10-13 17:25 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d77a27d0910130128p4a16d0e2p25833a6e90ee4445@mail.gmail.com \
--to=freephp@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox