From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27655 invoked by alias); 13 Oct 2009 08:28:48 -0000 Received: (qmail 27647 invoked by uid 22791); 13 Oct 2009 08:28:47 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-qy0-f185.google.com (HELO mail-qy0-f185.google.com) (209.85.221.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 08:28:42 +0000 Received: by qyk15 with SMTP id 15so8345597qyk.23 for ; Tue, 13 Oct 2009 01:28:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.13.219 with SMTP id d27mr2587554qca.56.1255422521093; Tue, 13 Oct 2009 01:28:41 -0700 (PDT) In-Reply-To: References: <4AD35AB6.2050903@vmware.com> <7d77a27d0910121917w4abfc09cx43e5667393ef9f79@mail.gmail.com> From: Jiang Jilin Date: Tue, 13 Oct 2009 08:28:00 -0000 Message-ID: <7d77a27d0910130128p4a16d0e2p25833a6e90ee4445@mail.gmail.com> Subject: Re: [RFA] Fix off-by-one error in record.c (record_list_release_first) To: Hui Zhu Cc: Michael Snyder , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00262.txt.bz2 On Tue, Oct 13, 2009 at 2:46 PM, Hui Zhu wrote: > Thanks Michael and Jilin, > > I think the Michael's patch is more spend up. =A0Jilin's patch is more > clear and can handle set_record_insn_max_num. > > I suggest we choice speed up. =A0Do you think it's OK? Agree with you. :) > If we choice it, Michael, could you please add some comments to > "record_list_release_first" or change it's name to > "record_list_release_first_without_update_xxx" to make it clear. > And please update set_record_insn_max_num. > > Thanks, > Hui > --=20 Jiang