From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter
Date: Wed, 20 Jan 2016 18:45:00 -0000 [thread overview]
Message-ID: <7d72670c5408364836087232281fba75@simark.ca> (raw)
In-Reply-To: <569FCFE6.8020002@redhat.com>
On 2016-01-20 13:20, Pedro Alves wrote:
> On 01/20/2016 06:10 PM, Simon Marchi wrote:
>
>> I noticed that I could change the regexps to almost anything and the
>> tests would still pass. I think it was because of the | in there.
>> I
>> made them more robust by using string_to_regexp.
>
> You can use gdb_test_exact instead, which does the string_to_regexp
> for you. OK with that change.
Ok, pushed with that change.
Thanks.
prev parent reply other threads:[~2016-01-20 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 18:10 Simon Marchi
2016-01-20 18:20 ` Pedro Alves
2016-01-20 18:45 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d72670c5408364836087232281fba75@simark.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox