From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105757 invoked by alias); 20 Jan 2016 18:45:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105730 invoked by uid 89); 20 Jan 2016 18:45:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*UA:Webmail X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Jan 2016 18:45:32 +0000 Received: by simark.ca (Postfix, from userid 112) id 6FA4F1E042; Wed, 20 Jan 2016 13:45:31 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 510771E042; Wed, 20 Jan 2016 13:45:29 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 20 Jan 2016 18:45:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix sorting of enum values in FlagEnumerationPrinter In-Reply-To: <569FCFE6.8020002@redhat.com> References: <1453313447-21194-1-git-send-email-simon.marchi@polymtl.ca> <569FCFE6.8020002@redhat.com> Message-ID: <7d72670c5408364836087232281fba75@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.1.3 X-SW-Source: 2016-01/txt/msg00489.txt.bz2 On 2016-01-20 13:20, Pedro Alves wrote: > On 01/20/2016 06:10 PM, Simon Marchi wrote: > >> I noticed that I could change the regexps to almost anything and the >> tests would still pass. I think it was because of the | in there. >> I >> made them more robust by using string_to_regexp. > > You can use gdb_test_exact instead, which does the string_to_regexp > for you. OK with that change. Ok, pushed with that change. Thanks.