From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org
Subject: Re: [RFAv3 2/5] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args to info [args|functions|locals|variables]
Date: Mon, 22 Oct 2018 14:16:00 -0000 [thread overview]
Message-ID: <7cdfd0a8-4d21-1326-e04f-636c4d86086c@redhat.com> (raw)
In-Reply-To: <20180923214209.985-3-philippe.waroquiers@skynet.be>
On 09/23/2018 10:42 PM, Philippe Waroquiers wrote:
> @@ -2043,14 +2055,37 @@ do_print_variable_and_value (const char *print_name,
> p->values_printed = 1;
> }
>
> +/* Prepares the regular expression REG from REGEXP.
> + If REGEXP is NULL, it results in an empty regular expression. */
> +static void
Space between comment and function.
> +prepare_reg (const char *regexp, gdb::optional<compiled_regex> *reg)
> +{
> @@ -2121,7 +2173,6 @@ iterate_over_block_arg_vars (const struct block *b,
> symbol is double and the type of the LOC_LOCAL symbol is
> float). There are also LOC_ARG/LOC_REGISTER pairs which
> are not combined in symbol-reading. */
> -
> sym2 = lookup_symbol_search_name (SYMBOL_SEARCH_NAME (sym),
> b, VAR_DOMAIN).symbol;
> (*cb) (SYMBOL_PRINT_NAME (sym), sym2, cb_data);
Spurious change?
Really no further comments here. :-)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-10-22 14:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 21:42 [RFAv3 0/5] info [args|functions|locals|variables] [-q] [-t TYPEREGEXP] [NAMEREGEXP] Philippe Waroquiers
2018-09-23 21:42 ` [RFAv3 4/5] Announce changes in NEWS to info [args|functions|locals|variables] Philippe Waroquiers
2018-09-24 6:59 ` Eli Zaretskii
2018-09-23 21:42 ` [RFAv3 3/5] Document changes " Philippe Waroquiers
2018-09-24 7:03 ` Eli Zaretskii
2018-10-22 14:17 ` Pedro Alves
2018-09-23 21:42 ` [RFAv3 2/5] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args " Philippe Waroquiers
2018-10-22 14:16 ` Pedro Alves [this message]
2018-09-23 21:42 ` [RFAv3 5/5] Add a test case for info args|functions|locals|variables [-q] [-t TYPEREGEXP] [NAMEREGEXP] Philippe Waroquiers
2018-10-22 14:19 ` Pedro Alves
2018-10-23 22:05 ` Philippe Waroquiers
2018-10-24 17:18 ` Pedro Alves
2018-09-23 21:42 ` [RFAv3 1/5] New cli-utils.h/.c function extract_info_print_args Philippe Waroquiers
2018-10-22 14:16 ` Pedro Alves
2018-10-23 21:59 ` Philippe Waroquiers
2018-10-24 17:03 ` Pedro Alves
2018-10-02 18:17 ` [RFAv3 0/5] info [args|functions|locals|variables] [-q] [-t TYPEREGEXP] [NAMEREGEXP] Philippe Waroquiers
2018-10-11 19:56 ` PING^2 " Philippe Waroquiers
2018-10-18 19:37 ` PING^3 " Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cdfd0a8-4d21-1326-e04f-636c4d86086c@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox