From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47683 invoked by alias); 22 Oct 2018 14:16:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47654 invoked by uid 89); 22 Oct 2018 14:16:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KAM_STOCKGEN,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=waroquiers, Philippe, Waroquiers X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Oct 2018 14:16:45 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D1383097031; Mon, 22 Oct 2018 14:16:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6289E27C28; Mon, 22 Oct 2018 14:16:43 +0000 (UTC) From: Pedro Alves Subject: Re: [RFAv3 2/5] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args to info [args|functions|locals|variables] To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20180923214209.985-1-philippe.waroquiers@skynet.be> <20180923214209.985-3-philippe.waroquiers@skynet.be> Message-ID: <7cdfd0a8-4d21-1326-e04f-636c4d86086c@redhat.com> Date: Mon, 22 Oct 2018 14:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180923214209.985-3-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00474.txt.bz2 On 09/23/2018 10:42 PM, Philippe Waroquiers wrote: > @@ -2043,14 +2055,37 @@ do_print_variable_and_value (const char *print_name, > p->values_printed = 1; > } > > +/* Prepares the regular expression REG from REGEXP. > + If REGEXP is NULL, it results in an empty regular expression. */ > +static void Space between comment and function. > +prepare_reg (const char *regexp, gdb::optional *reg) > +{ > @@ -2121,7 +2173,6 @@ iterate_over_block_arg_vars (const struct block *b, > symbol is double and the type of the LOC_LOCAL symbol is > float). There are also LOC_ARG/LOC_REGISTER pairs which > are not combined in symbol-reading. */ > - > sym2 = lookup_symbol_search_name (SYMBOL_SEARCH_NAME (sym), > b, VAR_DOMAIN).symbol; > (*cb) (SYMBOL_PRINT_NAME (sym), sym2, cb_data); Spurious change? Really no further comments here. :-) Thanks, Pedro Alves