Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/3] PR python/17698 - add Breakpoint.pending
Date: Fri, 20 May 2016 14:29:00 -0000	[thread overview]
Message-ID: <7bf927e6-5420-112e-8046-2b391741fb7f@redhat.com> (raw)
In-Reply-To: <1463695563-4130-4-git-send-email-tom@tromey.com>

On 19/05/16 23:06, Tom Tromey wrote:
> This patch adds a "pending" attribute to gdb.Breakpoint.
> 
> Built and regtested on x86-64 Fedora 23.
> 
> 2016-05-19  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/17698:
> 	* NEWS: Update.
> 	* python/py-breakpoint.c (bppy_get_pending): New function.
> 	(breakpoint_object_getset): Add entry for "pending".
> 	* breakpoint.h (pending_breakpoint_p): Declare.
> 	* breakpoint.c (pending_breakpoint_p): New function.
> 
> 2016-05-19  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/17698:
> 	* python.texi (Breakpoints In Python): Document
> 	Breakpoint.pending.
> 
> 2016-05-19  Tom Tromey  <tom@tromey.com>
> 
> 	PR python/17698:
> 	* gdb.python/py-breakpoint.exp (test_bkpt_basic): Add "pending"
> 	test.
> 	(test_watchpoints): Likewise.
> 	(test_bkpt_pending): New proc.

Looks good to me!

Cheers
Phil


  parent reply	other threads:[~2016-05-20 14:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 22:06 [RFA 0/4] Add "pending" attribute to gdb.Breakpoint Tom Tromey
2016-05-19 22:06 ` [RFA 3/3] PR python/17698 - add Breakpoint.pending Tom Tromey
2016-05-20  5:46   ` Eli Zaretskii
2016-05-20 14:29   ` Phil Muldoon [this message]
2016-07-13  8:16   ` Yao Qi
2016-05-19 22:06 ` [RFA 2/3] use user_breakpoint_p in python code Tom Tromey
2016-05-20 14:30   ` Phil Muldoon
2016-07-13  8:09   ` Yao Qi
2016-05-19 22:06 ` [RFA 1/3] Rearrange Python breakpoint node in documentation Tom Tromey
2016-05-20  5:45   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bf927e6-5420-112e-8046-2b391741fb7f@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox