From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove cleanup from remote.c
Date: Mon, 07 Jan 2019 01:15:00 -0000 [thread overview]
Message-ID: <7b11d6b4925f1ac7c0436d236be15824@polymtl.ca> (raw)
In-Reply-To: <20190106201224.16653-1-tom@tromey.com>
On 2019-01-06 15:12, Tom Tromey wrote:
> This removes the remaining cleanup from remote.c, by changing
> remote_state::buf to be a gdb::char_vector, and then fixing up all the
> fallout. The resulting patch is somewhat ugly, but on the other hand,
> it eliminates some possibilities for mistakes.
>
> Regression tested using the
> Fedora-x86_64-native-extended-gdbserver-m64 builder on the buildbot.
All of this for a single cleanup :). This is fine with me. I think we
could later get rid of a few ->data() by having some functions take a
gdb::char_vector or gdb::array_view instead of a char*.
Simon
prev parent reply other threads:[~2019-01-07 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 20:12 Tom Tromey
2019-01-07 1:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b11d6b4925f1ac7c0436d236be15824@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox