From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16971 invoked by alias); 7 Jan 2019 01:15:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15693 invoked by uid 89); 7 Jan 2019 01:15:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=mistakes X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 01:15:00 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x071EslL000679 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 6 Jan 2019 20:14:58 -0500 Received: by simark.ca (Postfix, from userid 112) id EC4241E7B1; Sun, 6 Jan 2019 20:14:53 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id A15851E4B1; Sun, 6 Jan 2019 20:14:52 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 07 Jan 2019 01:15:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove cleanup from remote.c In-Reply-To: <20190106201224.16653-1-tom@tromey.com> References: <20190106201224.16653-1-tom@tromey.com> Message-ID: <7b11d6b4925f1ac7c0436d236be15824@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00099.txt.bz2 On 2019-01-06 15:12, Tom Tromey wrote: > This removes the remaining cleanup from remote.c, by changing > remote_state::buf to be a gdb::char_vector, and then fixing up all the > fallout. The resulting patch is somewhat ugly, but on the other hand, > it eliminates some possibilities for mistakes. > > Regression tested using the > Fedora-x86_64-native-extended-gdbserver-m64 builder on the buildbot. All of this for a single cleanup :). This is fine with me. I think we could later get rid of a few ->data() by having some functions take a gdb::char_vector or gdb::array_view instead of a char*. Simon