From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>,
gdb-patches@sourceware.org, qiyaoltc@gmail.com
Subject: Re: [PATCH] PR21166: Validate rdrand/rdseed support separately in gdb.reverse/insn-reverse-x86.c
Date: Thu, 23 Feb 2017 20:00:00 -0000 [thread overview]
Message-ID: <79cd6855-726b-709e-188b-34345f554626@redhat.com> (raw)
In-Reply-To: <9d8d749f-ddec-8830-a3f0-e8ee82b51c32@redhat.com>
On 02/23/2017 07:51 PM, Pedro Alves wrote:
> On 02/23/2017 07:29 PM, Luis Machado wrote:
>> As reported in PR21166, there are Intel processors out there that support
>> rdrand but not rdseed. The fix is to verify both features separately and only
>> run rdrand/rdseed tests if supported.
>>
>> Pedro, could you please confirm this fixes what you see in your Fedora box?
>
> Will do.
Below's what I see when running insn-reverse.exp. Ship it!
Thanks for fixing this. It'd also be nice to fix the Tcl
ERROR.
Test run by pedro on Thu Feb 23 19:55:45 2017
Native configuration is x86_64-pc-linux-gnu
=== gdb tests ===
Schedule of variations:
unix
Running target unix
Running src/gdb/testsuite/gdb.reverse/insn-reverse.exp ...
PASS: gdb.reverse/insn-reverse.exp: get integer valueof "n_testcases" (2)
PASS: gdb.reverse/insn-reverse.exp: rdrand: continue
PASS: gdb.reverse/insn-reverse.exp: rdrand: turn on process record
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 0:mov 0x2009e7(%rip),%eax # 0x601058 <supports_rdrand>
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 1:test %eax,%eax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 2:je 0x400783 <rdrand+284>
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 3:rdrand %ax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 4:rdrand %bx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 5:rdrand %cx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 6:rdrand %dx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 7:mov %di,%ax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 8:rdrand %di
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 9:mov %ax,%di
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 10:mov %si,%ax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 11:rdrand %si
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 12:mov %ax,%si
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 13:mov %bp,%ax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 14:rdrand %bp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 15:mov %ax,%bp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 16:mov %sp,%ax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 17:rdrand %sp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 18:mov %ax,%sp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 19:rdrand %r8w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 20:rdrand %r9w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 21:rdrand %r10w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 22:rdrand %r11w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 23:rdrand %r12w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 24:rdrand %r13w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 25:rdrand %r14w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 26:rdrand %r15w
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 27:rdrand %eax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 28:rdrand %ebx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 29:rdrand %ecx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 30:rdrand %edx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 31:mov %rdi,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 32:rdrand %edi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 33:mov %rax,%rdi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 34:mov %rsi,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 35:rdrand %esi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 36:mov %rax,%rsi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 37:mov %rbp,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 38:rdrand %ebp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 39:mov %rax,%rbp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 40:mov %rsp,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 41:rdrand %esp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 42:mov %rax,%rsp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 43:rdrand %r8d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 44:rdrand %r9d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 45:rdrand %r10d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 46:rdrand %r11d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 47:rdrand %r12d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 48:rdrand %r13d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 49:rdrand %r14d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 50:rdrand %r15d
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 51:rdrand %rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 52:rdrand %rbx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 53:rdrand %rcx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 54:rdrand %rdx
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 55:mov %rdi,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 56:rdrand %rdi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 57:mov %rax,%rdi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 58:mov %rsi,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 59:rdrand %rsi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 60:mov %rax,%rsi
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 61:mov %rbp,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 62:rdrand %rbp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 63:mov %rax,%rbp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 64:mov %rsp,%rax
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 65:rdrand %rsp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 66:mov %rax,%rsp
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 67:rdrand %r8
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 68:rdrand %r9
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 69:rdrand %r10
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 70:rdrand %r11
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 71:rdrand %r12
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 72:rdrand %r13
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 73:rdrand %r14
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 74:rdrand %r15
PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 75:jmp 0x400784 <rdrand+285>
PASS: gdb.reverse/insn-reverse.exp: rdrand: record stop
PASS: gdb.reverse/insn-reverse.exp: rdseed: continue
PASS: gdb.reverse/insn-reverse.exp: rdseed: turn on process record
PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 0:mov 0x2008cc(%rip),%eax # 0x60105c <supports_rdseed>
PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 1:test %eax,%eax
PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 2:je 0x4008a2 <rdseed+284>
PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 3:nop
PASS: gdb.reverse/insn-reverse.exp: rdseed: record stop
=== gdb Summary ===
# of expected passes 87
next prev parent reply other threads:[~2017-02-23 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 19:29 Luis Machado
2017-02-23 19:51 ` Pedro Alves
2017-02-23 20:00 ` Pedro Alves [this message]
2017-02-23 20:43 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79cd6855-726b-709e-188b-34345f554626@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox