From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3527 invoked by alias); 23 Feb 2017 20:00:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3514 invoked by uid 89); 23 Feb 2017 20:00:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Tcl, valueof, H*f:sk:9d8d749, H*MI:sk:9d8d749 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 20:00:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AC1B85543; Thu, 23 Feb 2017 20:00:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1NK0DEF003280; Thu, 23 Feb 2017 15:00:14 -0500 Subject: Re: [PATCH] PR21166: Validate rdrand/rdseed support separately in gdb.reverse/insn-reverse-x86.c To: Luis Machado , gdb-patches@sourceware.org, qiyaoltc@gmail.com References: <1487878141-21578-1-git-send-email-lgustavo@codesourcery.com> <9d8d749f-ddec-8830-a3f0-e8ee82b51c32@redhat.com> From: Pedro Alves Message-ID: <79cd6855-726b-709e-188b-34345f554626@redhat.com> Date: Thu, 23 Feb 2017 20:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9d8d749f-ddec-8830-a3f0-e8ee82b51c32@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00649.txt.bz2 On 02/23/2017 07:51 PM, Pedro Alves wrote: > On 02/23/2017 07:29 PM, Luis Machado wrote: >> As reported in PR21166, there are Intel processors out there that support >> rdrand but not rdseed. The fix is to verify both features separately and only >> run rdrand/rdseed tests if supported. >> >> Pedro, could you please confirm this fixes what you see in your Fedora box? > > Will do. Below's what I see when running insn-reverse.exp. Ship it! Thanks for fixing this. It'd also be nice to fix the Tcl ERROR. Test run by pedro on Thu Feb 23 19:55:45 2017 Native configuration is x86_64-pc-linux-gnu === gdb tests === Schedule of variations: unix Running target unix Running src/gdb/testsuite/gdb.reverse/insn-reverse.exp ... PASS: gdb.reverse/insn-reverse.exp: get integer valueof "n_testcases" (2) PASS: gdb.reverse/insn-reverse.exp: rdrand: continue PASS: gdb.reverse/insn-reverse.exp: rdrand: turn on process record PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 0:mov 0x2009e7(%rip),%eax # 0x601058 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 1:test %eax,%eax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 2:je 0x400783 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 3:rdrand %ax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 4:rdrand %bx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 5:rdrand %cx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 6:rdrand %dx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 7:mov %di,%ax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 8:rdrand %di PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 9:mov %ax,%di PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 10:mov %si,%ax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 11:rdrand %si PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 12:mov %ax,%si PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 13:mov %bp,%ax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 14:rdrand %bp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 15:mov %ax,%bp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 16:mov %sp,%ax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 17:rdrand %sp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 18:mov %ax,%sp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 19:rdrand %r8w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 20:rdrand %r9w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 21:rdrand %r10w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 22:rdrand %r11w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 23:rdrand %r12w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 24:rdrand %r13w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 25:rdrand %r14w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 26:rdrand %r15w PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 27:rdrand %eax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 28:rdrand %ebx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 29:rdrand %ecx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 30:rdrand %edx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 31:mov %rdi,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 32:rdrand %edi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 33:mov %rax,%rdi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 34:mov %rsi,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 35:rdrand %esi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 36:mov %rax,%rsi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 37:mov %rbp,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 38:rdrand %ebp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 39:mov %rax,%rbp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 40:mov %rsp,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 41:rdrand %esp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 42:mov %rax,%rsp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 43:rdrand %r8d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 44:rdrand %r9d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 45:rdrand %r10d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 46:rdrand %r11d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 47:rdrand %r12d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 48:rdrand %r13d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 49:rdrand %r14d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 50:rdrand %r15d PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 51:rdrand %rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 52:rdrand %rbx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 53:rdrand %rcx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 54:rdrand %rdx PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 55:mov %rdi,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 56:rdrand %rdi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 57:mov %rax,%rdi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 58:mov %rsi,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 59:rdrand %rsi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 60:mov %rax,%rsi PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 61:mov %rbp,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 62:rdrand %rbp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 63:mov %rax,%rbp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 64:mov %rsp,%rax PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 65:rdrand %rsp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 66:mov %rax,%rsp PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 67:rdrand %r8 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 68:rdrand %r9 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 69:rdrand %r10 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 70:rdrand %r11 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 71:rdrand %r12 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 72:rdrand %r13 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 73:rdrand %r14 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 74:rdrand %r15 PASS: gdb.reverse/insn-reverse.exp: rdrand: compare registers on insn 75:jmp 0x400784 PASS: gdb.reverse/insn-reverse.exp: rdrand: record stop PASS: gdb.reverse/insn-reverse.exp: rdseed: continue PASS: gdb.reverse/insn-reverse.exp: rdseed: turn on process record PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 0:mov 0x2008cc(%rip),%eax # 0x60105c PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 1:test %eax,%eax PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 2:je 0x4008a2 PASS: gdb.reverse/insn-reverse.exp: rdseed: compare registers on insn 3:nop PASS: gdb.reverse/insn-reverse.exp: rdseed: record stop === gdb Summary === # of expected passes 87