From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Support large registers in regcache transfer_regset
Date: Tue, 19 Jun 2018 21:12:00 -0000 [thread overview]
Message-ID: <794eac822cdad5025f9777712bdaf95a@simark.ca> (raw)
In-Reply-To: <AFFC93A3-E4DE-4DDD-AE2D-53ECD0551DA2@arm.com>
On 2018-06-19 11:46, Alan Hayward wrote:
> Ah, ok. If doing that, then it’d make sense to update
> regcache_map_entry to use
> unsigned ints for count and size.
>
> struct regcache_map_entry
> {
> int count;
> int regno;
> int size;
> };
>
> At that point it probably makes sense to repost the patch as v2 in
> smaller pieces?
If you end up doing this (I did not really dig much to see if it works),
then yes it might make sense to have a preparatory patch that changes
some types to be unsigned. As always, one logical change per patch is
appreciated and is much easier to review.
If you're going to send a proper v2, I'll wait for this one to look at
the new changes you sent as part of the "updated" v1.
Simon
prev parent reply other threads:[~2018-06-19 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 8:04 Alan Hayward
2018-06-17 2:52 ` Simon Marchi
2018-06-19 11:28 ` Alan Hayward
2018-06-19 14:52 ` Simon Marchi
2018-06-19 15:46 ` Alan Hayward
2018-06-19 21:12 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794eac822cdad5025f9777712bdaf95a@simark.ca \
--to=simark@simark.ca \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox