From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-148344-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 50648 invoked by alias); 19 Jun 2018 21:12:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 50636 invoked by uid 89); 19 Jun 2018 21:11:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=dig, HContent-Transfer-Encoding:8bit
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Jun 2018 21:11:58 +0000
Received: by simark.ca (Postfix, from userid 112)	id D27271EF29; Tue, 19 Jun 2018 17:11:56 -0400 (EDT)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id AD93A1E529;	Tue, 19 Jun 2018 17:11:55 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Date: Tue, 19 Jun 2018 21:12:00 -0000
From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Support large registers in regcache transfer_regset
In-Reply-To: <AFFC93A3-E4DE-4DDD-AE2D-53ECD0551DA2@arm.com>
References: <20180612080356.33157-1-alan.hayward@arm.com> <6bba6aa4-c350-e5fb-3913-823eccae60ef@simark.ca> <85CCB6E0-63F0-4298-B328-D43D3207A91E@arm.com> <d3bb9490d3f0e4aa45e02f44953ef51d@simark.ca> <AFFC93A3-E4DE-4DDD-AE2D-53ECD0551DA2@arm.com>
Message-ID: <794eac822cdad5025f9777712bdaf95a@simark.ca>
X-Sender: simark@simark.ca
User-Agent: Roundcube Webmail/1.3.6
X-SW-Source: 2018-06/txt/msg00487.txt.bz2

On 2018-06-19 11:46, Alan Hayward wrote:
> Ah, ok. If doing that, then it’d make sense to update 
> regcache_map_entry to use
> unsigned ints for count and size.
> 
> struct regcache_map_entry
> {
>   int count;
>   int regno;
>   int size;
> };
> 
> At that point it probably makes sense to repost the patch as v2 in
> smaller pieces?

If you end up doing this (I did not really dig much to see if it works), 
then yes it might make sense to have a preparatory patch that changes 
some types to be unsigned.  As always, one logical change per patch is 
appreciated and is much easier to review.

If you're going to send a proper v2, I'll wait for this one to look at 
the new changes you sent as part of the "updated" v1.

Simon