From: John Baldwin <jhb@FreeBSD.org>
To: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 0/6] Demangle minimal symbol names in worker threads
Date: Mon, 11 Mar 2019 17:35:00 -0000 [thread overview]
Message-ID: <78689a07-247d-7481-75b8-416ed605a879@FreeBSD.org> (raw)
In-Reply-To: <83tvgb7we9.fsf@gnu.org>
On 3/9/19 10:09 AM, Eli Zaretskii wrote:
>> From: Tom Tromey <tom@tromey.com>
>> Date: Sat, 9 Mar 2019 10:22:54 -0700
>>
>> I've thought for a while that gdb should take advantage of multiple
>> cores in order to speed up its processing. This series is some
>> initial work in that direction.
>>
>> In particular, this patch arranges to do the demangling for minimal
>> symbols in worker threads. I chose this because it seemed relatively
>> simple to reason about, as the demangler is already mostly thread-safe
>> (except, as it turns out, the Ada demangler, which is fixed in this
>> series). It isn't actually a very important thing to speed up, as
>> minimal symbol reading is already reasonably speedy; but I thought it
>> best to start with something straightforward to facilitate flushing
>> out thread safety bugs.
>
> Thanks, but is std::thread portable enough? E.g., I recall problems
> with it in MinGW.
>
> Same question regarding delivering signals to threads.
I can't speak to MinGW, but the signal in question here is a synchronous
SIGSEGV signal due to a page fault or the like and in POSIX systems that
is always sent to the thread executing the faulting instruction (and that
is the only sane semantic since the thread can't execute any more
instructions until the signal is resolved).
--
John Baldwin
next prev parent reply other threads:[~2019-03-11 17:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 17:23 Tom Tromey
2019-03-09 17:23 ` [RFC 6/6] Demangle minsyms in parallel Tom Tromey
2019-03-09 17:23 ` [RFC 3/6] Lock the demangled hash table Tom Tromey
2019-03-09 17:23 ` [RFC 1/6] Defer minimal symbol name-setting Tom Tromey
2019-03-09 17:23 ` [RFC 4/6] Introduce run_on_main_thread Tom Tromey
2019-03-09 17:23 ` [RFC 2/6] Remove static buffer from ada_decode Tom Tromey
2019-03-09 17:23 ` [RFC 5/6] Introduce thread-safe way to handle SIGSEGV Tom Tromey
2019-03-11 17:24 ` John Baldwin
2019-03-09 18:09 ` [RFC 0/6] Demangle minimal symbol names in worker threads Eli Zaretskii
2019-03-11 17:35 ` John Baldwin [this message]
2019-03-11 22:39 ` Tom Tromey
2019-03-12 3:33 ` Eli Zaretskii
2019-03-13 15:38 ` Eli Zaretskii
2019-03-15 23:28 ` Tom Tromey
2019-03-16 7:46 ` Eli Zaretskii
2019-03-16 8:31 ` Eli Zaretskii
2019-03-15 23:40 ` Tom Tromey
2019-03-16 7:52 ` Eli Zaretskii
2019-03-11 17:26 ` John Baldwin
2019-03-11 22:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78689a07-247d-7481-75b8-416ed605a879@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox