From: Pedro Alves <palves@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Cc: Mark Rages <markrages@gmail.com>
Subject: Re: [PATCH] Re: Flash memory size not aligned to address
Date: Wed, 11 Oct 2017 16:11:00 -0000 [thread overview]
Message-ID: <77f0b922-94a8-57a7-32a2-9007a6efff78@redhat.com> (raw)
In-Reply-To: <20171011085355.78e0466e@pinnacle.lan>
On 10/11/2017 04:53 PM, Kevin Buettner wrote:
> I gather it too late to amend it now, right? (Since git commit --amend
> only works on the most recent commit.)
Right, it's too late, but the reason is we don't allow history
rewrites of the upstream repo; we only allow fast-forward merges
to keep history linear -- even if it were the most recent commit,
you wouldn't be able to push it. (And it's possible to amend
more than one commit.) The closest would be to revert the patch, and
reapply the original patch with author fixed. (Not sure it's
worth complicating git history a bit, but it's easy enough to
do if desired.)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-10-11 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 21:49 Mark Rages
2017-10-07 18:36 ` [PATCH] " Mark Rages
2017-10-07 21:42 ` Kevin Buettner
2017-10-09 16:28 ` Mark Rages
2017-10-09 17:51 ` Kevin Buettner
2017-10-09 19:08 ` Mark Rages
2017-10-11 7:56 ` Kevin Buettner
2017-10-11 9:31 ` Pedro Alves
2017-10-11 15:54 ` Kevin Buettner
2017-10-11 16:11 ` Pedro Alves [this message]
2017-10-11 16:27 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77f0b922-94a8-57a7-32a2-9007a6efff78@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=markrages@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox