From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 755 invoked by alias); 11 Oct 2017 16:11:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 451 invoked by uid 89); 11 Oct 2017 16:11:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Oct 2017 16:11:20 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7359B820EE; Wed, 11 Oct 2017 16:11:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7359B820EE Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91EA46E716; Wed, 11 Oct 2017 16:11:18 +0000 (UTC) Subject: Re: [PATCH] Re: Flash memory size not aligned to address To: Kevin Buettner , gdb-patches@sourceware.org References: <20171007144252.05e2b69e@pinnacle.lan> <20171009105111.1a44f9e9@pinnacle.lan> <20171011005613.56c1cac9@pinnacle.lan> <684fd87f-3a01-0725-6b75-bb4bd4aad367@redhat.com> <20171011085355.78e0466e@pinnacle.lan> Cc: Mark Rages From: Pedro Alves Message-ID: <77f0b922-94a8-57a7-32a2-9007a6efff78@redhat.com> Date: Wed, 11 Oct 2017 16:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171011085355.78e0466e@pinnacle.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00298.txt.bz2 On 10/11/2017 04:53 PM, Kevin Buettner wrote: > I gather it too late to amend it now, right? (Since git commit --amend > only works on the most recent commit.) Right, it's too late, but the reason is we don't allow history rewrites of the upstream repo; we only allow fast-forward merges to keep history linear -- even if it were the most recent commit, you wouldn't be able to push it. (And it's possible to amend more than one commit.) The closest would be to revert the patch, and reapply the original patch with author fixed. (Not sure it's worth complicating git history a bit, but it's easy enough to do if desired.) Thanks, Pedro Alves