Re: [PATCH] Move gnulib to top level

[Tom de Vries <tdevries@suse.de>]

On 13-06-19 15:29, Pedro Alves wrote:
> On 6/13/19 1:48 PM, Tom Tromey wrote:
>> This patch moves the gdb/gnulib subdirectory to the top level.
>>
>> It adjusts the top-level build system to build gnulib when necessary,
>> and changes gdb to use this.  However, gdbserver still builds its own
>> copy of gnulib, just from the new source location.
>>
>> A small hack was needed to ensure that gnulib is only built when gdb
>> is enabled.  The Makefile only provides an ordering -- the directory
>> must be mentioned in configdirs to actually be compiled at all.
>>
>> Most of the patch is just a "git mv" of gnulib, though a few minor
>> path adjustments were needed in some files there.
>>
> 
> Also, gnulib/configure.ac is using ACX_LARGEFILE now.
> 
>> Tested by the buildbot.
>>
> 
> I think we'll need the following, though not necessarily
> in this patch:
> 
>  - a gnulib/README file
>  - to list gnulib in top/MAINTAINERS
> 
> LGTM.
> 
> I'm sure you know, but JIC, the top-level changes will
> need to go to gcc too.
> 

It seems gnulib is missing from
ftp://sourceware.org/pub/gdb/snapshots/current/gdb-weekly-8.3.50.20190618.tar.xz:
...
$ find gdb-8.3.50.20190611 -name gnulib
gdb-8.3.50.20190611/gdb/gnulib
$ find gdb-8.3.50.20190618 -name gnulib
$
...

So, the build fails:
...
mkdir -p -- ./gnulib
Configuring in ./gnulib
/bin/sh: /root/gdb/src/gnulib/configure: No such file or directory
...

Thanks,
- Tom