From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119051 invoked by alias); 19 Jun 2019 15:56:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119042 invoked by uid 89); 19 Jun 2019 15:56:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=snapshots, jic, sk:gdb-8.3, sk:gdb-wee X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Jun 2019 15:56:04 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 70003AC41; Wed, 19 Jun 2019 15:56:02 +0000 (UTC) Subject: Re: [PATCH] Move gnulib to top level To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20190613124818.15130-1-tom@tromey.com> <229bf3df-3fe3-60e1-cfec-448810839fa5@redhat.com> From: Tom de Vries Message-ID: <777f0d31-6cf5-cd98-8411-c965c9a7dc9f@suse.de> Date: Wed, 19 Jun 2019 15:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <229bf3df-3fe3-60e1-cfec-448810839fa5@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00385.txt.bz2 On 13-06-19 15:29, Pedro Alves wrote: > On 6/13/19 1:48 PM, Tom Tromey wrote: >> This patch moves the gdb/gnulib subdirectory to the top level. >> >> It adjusts the top-level build system to build gnulib when necessary, >> and changes gdb to use this. However, gdbserver still builds its own >> copy of gnulib, just from the new source location. >> >> A small hack was needed to ensure that gnulib is only built when gdb >> is enabled. The Makefile only provides an ordering -- the directory >> must be mentioned in configdirs to actually be compiled at all. >> >> Most of the patch is just a "git mv" of gnulib, though a few minor >> path adjustments were needed in some files there. >> > > Also, gnulib/configure.ac is using ACX_LARGEFILE now. > >> Tested by the buildbot. >> > > I think we'll need the following, though not necessarily > in this patch: > > - a gnulib/README file > - to list gnulib in top/MAINTAINERS > > LGTM. > > I'm sure you know, but JIC, the top-level changes will > need to go to gcc too. > It seems gnulib is missing from ftp://sourceware.org/pub/gdb/snapshots/current/gdb-weekly-8.3.50.20190618.tar.xz: ... $ find gdb-8.3.50.20190611 -name gnulib gdb-8.3.50.20190611/gdb/gnulib $ find gdb-8.3.50.20190618 -name gnulib $ ... So, the build fails: ... mkdir -p -- ./gnulib Configuring in ./gnulib /bin/sh: /root/gdb/src/gnulib/configure: No such file or directory ... Thanks, - Tom