From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix PR python/20129 - use of non-existing variable
Date: Mon, 06 Jun 2016 19:05:00 -0000 [thread overview]
Message-ID: <7742a1cb-dc04-9cfb-4323-016e109d0973@redhat.com> (raw)
In-Reply-To: <1465233765-15675-1-git-send-email-tom@tromey.com>
On 06/06/16 18:22, Tom Tromey wrote:
> PR python/20129 concerns the error message one gets from a command
> like "disable frame-filter global NoSuchFilter". Currently this
> throws a second, unexpected, exception due to the use of a
> non-existing variable named "name".
>
> This patch adds regression tests and fixes a couple of spots to use
> the correct variable name.
>
> Built and regtested on x86-64 Fedora 23.
>
> 2016-06-06 Tom Tromey <tom@tromey.com>
>
> PR python/20129:
> * python/lib/gdb/command/frame_filters.py (_do_enable_frame_filter)
> (SetFrameFilterPriority._set_filter_priority): Use "frame_filter",
> not "name".
>
> 2016-06-06 Tom Tromey <tom@tromey.com>
>
> PR python/20129:
> * gdb.python/py-framefilter.exp: Add tests for setting priority
> and disabling of non-existent frame filter.
Tom,
It looks fine to me (and the original a buglet anyway).
Cheers
Phil
next prev parent reply other threads:[~2016-06-06 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:23 Tom Tromey
2016-06-06 19:05 ` Phil Muldoon [this message]
2016-06-29 15:00 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7742a1cb-dc04-9cfb-4323-016e109d0973@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox