From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81992 invoked by alias); 6 Jun 2016 19:05:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81974 invoked by uid 89); 6 Jun 2016 19:05:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=non-existent, concerns, spots, H*Ad:U*pmuldoon X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 06 Jun 2016 19:05:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9EE650F65; Mon, 6 Jun 2016 19:05:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-18.ams2.redhat.com [10.36.112.18]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u56J579i001852; Mon, 6 Jun 2016 15:05:08 -0400 Subject: Re: [RFA] Fix PR python/20129 - use of non-existing variable To: Tom Tromey , gdb-patches@sourceware.org References: <1465233765-15675-1-git-send-email-tom@tromey.com> From: Phil Muldoon Message-ID: <7742a1cb-dc04-9cfb-4323-016e109d0973@redhat.com> Date: Mon, 06 Jun 2016 19:05:00 -0000 MIME-Version: 1.0 In-Reply-To: <1465233765-15675-1-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00103.txt.bz2 On 06/06/16 18:22, Tom Tromey wrote: > PR python/20129 concerns the error message one gets from a command > like "disable frame-filter global NoSuchFilter". Currently this > throws a second, unexpected, exception due to the use of a > non-existing variable named "name". > > This patch adds regression tests and fixes a couple of spots to use > the correct variable name. > > Built and regtested on x86-64 Fedora 23. > > 2016-06-06 Tom Tromey > > PR python/20129: > * python/lib/gdb/command/frame_filters.py (_do_enable_frame_filter) > (SetFrameFilterPriority._set_filter_priority): Use "frame_filter", > not "name". > > 2016-06-06 Tom Tromey > > PR python/20129: > * gdb.python/py-framefilter.exp: Add tests for setting priority > and disabling of non-existent frame filter. Tom, It looks fine to me (and the original a buglet anyway). Cheers Phil