Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "gmail Vladimir Koković via Gdb-patches" <gdb-patches@sourceware.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: mingw --enable-tui
Date: Sun, 22 Nov 2020 18:06:26 +0100	[thread overview]
Message-ID: <7718f9dc-1235-19f5-3883-9f40ea89e850@gmail.com> (raw)
In-Reply-To: <83zh39wcte.fsf@gnu.org>

Hi,

I think it's about mingw64 and not curses.

If you look at the patch, the fix is ​​only in adding cast (int) which 
in my opinion belongs to the compiler.


On 22.11.20. 17:55, Eli Zaretskii wrote:
>> Cc: gdb-patches@sourceware.org
>> From: gmail Vladimir Koković <vladimir.kokovic@gmail.com>
>> Date: Sun, 22 Nov 2020 17:35:03 +0100
>>
>> For mingw, pdcurses is used, not ncurses.
>>
>> pdcurses curses.h:
>>
>> #if defined( CHTYPE_32)
>>     #if defined( CHTYPE_64)
>>         #error CHTYPE cannot be both CHTYPE_32 and CHTYPE_64
>>     #endif
>>     typedef uint32_t chtype;       /* chtypes will be 32 bits */
>> #else
>>     #define CHTYPE_64
>>     typedef uint64_t chtype;       /* chtypes will be 64 bits */
>>     #ifdef PDC_WIDE
>>        #define USING_COMBINING_CHARACTER_SCHEME
>>     #endif
>> #endif
> Thanks, then I guess the condition should be for PDCurses, not
> necessarily for MinGW64.  I see no reason to assume that MinGW64 GDB
> will always be built with PDCurses.
>

  reply	other threads:[~2020-11-22 17:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-22 11:44 gmail Vladimir Koković via Gdb-patches
2020-11-22 12:13 ` gmail Vladimir Koković via Gdb-patches
2020-11-22 15:31 ` Eli Zaretskii via Gdb-patches
2020-11-22 16:19   ` gmail Vladimir Koković via Gdb-patches
2020-11-22 16:23     ` Eli Zaretskii via Gdb-patches
2020-11-22 16:35       ` gmail Vladimir Koković via Gdb-patches
2020-11-22 16:55         ` Eli Zaretskii via Gdb-patches
2020-11-22 17:06           ` gmail Vladimir Koković via Gdb-patches [this message]
2020-11-22 17:20     ` Tom Tromey
2020-11-22 18:24       ` Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7718f9dc-1235-19f5-3883-9f40ea89e850@gmail.com \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=vladimir.kokovic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox