From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4rawCJiaul9qLgAAWB0awg (envelope-from ) for ; Sun, 22 Nov 2020 12:06:32 -0500 Received: by simark.ca (Postfix, from userid 112) id 164D81F0AB; Sun, 22 Nov 2020 12:06:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE9561E58D for ; Sun, 22 Nov 2020 12:06:31 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DA3B3858009; Sun, 22 Nov 2020 17:06:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DA3B3858009 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606064791; bh=rQSzj3gcBscajf1zo2lxFLQmi9O60iw8BYgw1HHFj+c=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Rq3Jl9upjN6LPAYDq+vVEqO4jlMZiaLEWuM0zzO8qE5Wfhmj7gQq4/bcT2FuXhinW ipvFVdBe/QvScpIbOTfFksKBWwiZ5THyl0s8Jy/Agl2mcJa4PQvzcFbCVMvYBlADRO CFLmXNhvJgHdVuZOsRWwpqiZWNZcXXPhNDrWySYs= Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 494943858009 for ; Sun, 22 Nov 2020 17:06:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 494943858009 Received: by mail-ej1-x62b.google.com with SMTP id o9so20038963ejg.1 for ; Sun, 22 Nov 2020 09:06:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=hURoJ33jSzI9Wbd0GTOnE8hkqZml2argRvl7h+JGxuQ=; b=pFQF+7tmbavZwX9Yi9SDHH7UDiHktAy3n0EVDLkGmKf3wuGlNGPnOVdatZfNpzCspr 33E+Ee4fsAwwqw1ZcNpfaNWhqQ5yqjeeyYQLJWxFLsvDoIfn/hKtBzSGaVl59tVwrGPC P8k1GXNzHm7FNmSW8pP4aDTznEFoP3kPuwM+gT+KRnmjyKPBWkGeHc7u0r/grgERMQDe UALf/MWwQm7YvFJ13zpdqG0FdgPcXJydgGzv5IMTYFhPo8H9onFkR0BwxZFNJH2I/e1D pIh7YxvSOg/6/2nU1WOFo3j7ad+r8C2pTokgqN/X3b7TVVQivbHMpV2SnhIFj3/7reT3 jpcg== X-Gm-Message-State: AOAM5337iyyhxJltvuUEts00R3jkqyWZ872UsTejw7RgvsbSztLN9cja RXa9VeO8lVOz7JWY0iOtfu8CfLjkAyM= X-Google-Smtp-Source: ABdhPJzhkA8T5ykxEutRvyN2z9MFOvgFhv4mynUV49SElClICBRIpsq4HZaapeYhhtcA5gJ33ZvQIw== X-Received: by 2002:a17:906:fcc2:: with SMTP id qx2mr42398972ejb.549.1606064788197; Sun, 22 Nov 2020 09:06:28 -0800 (PST) Received: from [192.168.0.13] ([95.180.105.28]) by smtp.gmail.com with ESMTPSA id n11sm3771493eds.3.2020.11.22.09.06.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Nov 2020 09:06:27 -0800 (PST) Subject: Re: mingw --enable-tui To: Eli Zaretskii References: <83h7phxvb0.fsf@gnu.org> <562f0b99-1fd9-27d4-997e-d4e53c790d03@gmail.com> <833611xswf.fsf@gnu.org> <83zh39wcte.fsf@gnu.org> Message-ID: <7718f9dc-1235-19f5-3883-9f40ea89e850@gmail.com> Date: Sun, 22 Nov 2020 18:06:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <83zh39wcte.fsf@gnu.org> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?gmail_Vladimir_Kokovi=C4=87_via_Gdb-patches?= Reply-To: =?UTF-8?Q?gmail_Vladimir_Kokovi=c4=87?= Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, I think it's about mingw64 and not curses. If you look at the patch, the fix is ​​only in adding cast (int) which in my opinion belongs to the compiler. On 22.11.20. 17:55, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: gmail Vladimir Koković >> Date: Sun, 22 Nov 2020 17:35:03 +0100 >> >> For mingw, pdcurses is used, not ncurses. >> >> pdcurses curses.h: >> >> #if defined( CHTYPE_32) >> #if defined( CHTYPE_64) >> #error CHTYPE cannot be both CHTYPE_32 and CHTYPE_64 >> #endif >> typedef uint32_t chtype; /* chtypes will be 32 bits */ >> #else >> #define CHTYPE_64 >> typedef uint64_t chtype; /* chtypes will be 64 bits */ >> #ifdef PDC_WIDE >> #define USING_COMBINING_CHARACTER_SCHEME >> #endif >> #endif > Thanks, then I guess the condition should be for PDCurses, not > necessarily for MinGW64. I see no reason to assume that MinGW64 GDB > will always be built with PDCurses. >