From: Luis Machado <luis.machado@linaro.org>
To: Shahab Vahedi <Shahab.Vahedi@synopsys.com>,
Shahab Vahedi <shahab.vahedi@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
Francois Bedard <Francois.Bedard@synopsys.com>,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [Regression] [PATCH] Do not print empty-group regs when printing general ones
Date: Fri, 28 Feb 2020 13:08:00 -0000 [thread overview]
Message-ID: <75f76108-a233-6fce-66a2-86452371e1be@linaro.org> (raw)
In-Reply-To: <CH2PR12MB3847E492663E7997CFAB1741A6070@CH2PR12MB3847.namprd12.prod.outlook.com>
On 1/31/20 7:34 AM, Shahab Vahedi wrote:
> This patch was reviewed once (as OK):
> https://sourceware.org/ml/gdb-patches/2020-01/msg00613.html
>
> Could someone review/merge it?
>
>
> Cheers,
> Shahab
>
FTR, this has broken general register printing for ARM/AArch64. Now
"info reg" shows nothing.
Given there are already remote stubs, probes and gdbservers running out
there, this is an undesirable change to have.
I had an IRC chat with Christian and he pointed me at some documentation
stating empty-group registers should not be printed, but i think this is
a case where the implementation has diverged from the documentation.
https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format
We could probably patch up any non-standard target description XML's
from now on, but the existing behavior may have to be preserved.
I haven't investigated this in depth yet to determine what can/should
change.
next prev parent reply other threads:[~2020-02-28 13:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 17:29 Shahab Vahedi
2020-01-20 23:04 ` Andrew Burgess
[not found] ` <CH2PR12MB3847E492663E7997CFAB1741A6070@CH2PR12MB3847.namprd12.prod.outlook.com>
2020-02-28 13:08 ` Luis Machado [this message]
2020-02-28 13:22 ` [Regression] " Christian Biesinger via gdb-patches
[not found] ` <9c256b27-4a00-8830-46e2-934922e39cc2@linaro.org>
2020-02-28 13:36 ` Shahab Vahedi
2020-02-28 13:51 ` Luis Machado
2020-02-28 14:08 ` Shahab Vahedi
2020-02-28 14:11 ` Christian Biesinger via gdb-patches
2020-02-28 14:15 ` Shahab Vahedi
2020-03-04 13:17 ` Luis Machado
2020-03-04 15:21 ` Shahab Vahedi
2020-03-04 16:14 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75f76108-a233-6fce-66a2-86452371e1be@linaro.org \
--to=luis.machado@linaro.org \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=Shahab.Vahedi@synopsys.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox