From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108038 invoked by alias); 28 Feb 2020 13:08:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108030 invoked by uid 89); 28 Feb 2020 13:08:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:CH2PR12, HX-Google-Smtp-Source:APXvYqzn, H*MI:sk:CH2PR12, H*f:sk:2020012 X-HELO: mail-qt1-f175.google.com Received: from mail-qt1-f175.google.com (HELO mail-qt1-f175.google.com) (209.85.160.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 13:08:19 +0000 Received: by mail-qt1-f175.google.com with SMTP id p34so1927274qtb.6 for ; Fri, 28 Feb 2020 05:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hMrV9nARqFlEDGYmgeCK2JI28fPU5L6PUuEDheK/SQg=; b=h2Awkb+3XRmYcy0r6y+WePIQqrejG9A7CRIwuafsH1YBp0AttLYF2J2pLrWTgB7X5u mnXB9oPTiVnfm24QOJBfqNnjPI3V1TAiXT0lnNIBkCnTW8/7fS8o4ucTuHO9CvXu5i5V gzw+WzNQ+OIZ7PwqSvN4w0rmer8t7DqlmOSvQ7t+ivt4WLCYWCMzBgaJBc8EJmd556aX F5A6FpFGomJn6BQpf9zqNv7zUKq+/XWrbfd32QCyED56T+VDxjzWNUywbdsi60AaO4sD nxC3Y8vgHSUbAnArQ0PbwSkArcwFvC7B0vWV0XN4GfnHSTw6hBYYmYzTSVs2eU6Cl2dJ PzjQ== Return-Path: Received: from [192.168.0.185] ([191.34.159.98]) by smtp.gmail.com with ESMTPSA id c10sm5034718qkb.4.2020.02.28.05.08.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 05:08:16 -0800 (PST) Subject: [Regression] [PATCH] Do not print empty-group regs when printing general ones To: Shahab Vahedi , Shahab Vahedi , "gdb-patches@sourceware.org" Cc: Claudiu Zissulescu , Francois Bedard , Andrew Burgess References: <20200120155315.30333-1-shahab.vahedi@gmail.com> From: Luis Machado Message-ID: <75f76108-a233-6fce-66a2-86452371e1be@linaro.org> Date: Fri, 28 Feb 2020 13:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg01038.txt.bz2 On 1/31/20 7:34 AM, Shahab Vahedi wrote: > This patch was reviewed once (as OK): > https://sourceware.org/ml/gdb-patches/2020-01/msg00613.html > > Could someone review/merge it? > > > Cheers, > Shahab > FTR, this has broken general register printing for ARM/AArch64. Now "info reg" shows nothing. Given there are already remote stubs, probes and gdbservers running out there, this is an undesirable change to have. I had an IRC chat with Christian and he pointed me at some documentation stating empty-group registers should not be printed, but i think this is a case where the implementation has diverged from the documentation. https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format We could probably patch up any non-standard target description XML's from now on, but the existing behavior may have to be preserved. I haven't investigated this in depth yet to determine what can/should change.