From: Luis Machado <lgustavo@codesourcery.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 0/8] Fix gdb's testsuite test names
Date: Mon, 28 Nov 2016 19:00:00 -0000 [thread overview]
Message-ID: <753fb1b5-93a0-4557-329e-aa3f39d3e0c9@codesourcery.com> (raw)
In-Reply-To: <87wpfn8mbd.fsf@redhat.com>
On 11/28/2016 12:57 PM, Sergio Durigan Junior wrote:
> On Friday, November 25 2016, Luis Machado wrote:
>
>> Changes in v2:
>>
>> * Patch 1/8 in v1 is now patch 8/8 in v2, due to organization issues. Patch 8/8
>> does a few additional things in v2. Patches 2~8 in v1 are now 1~7 in v2.
>>
>> Patch 1/8 and Patch 2/8
>> =========
>>
>> * Fixed spurious whitespaces.
>>
>> Patch 8/8
>> =========
>>
>> * Updated compilation failure message and replaced existing ones to keep them
>> standard.
>>
>> All other patches have no meaningful changes.
>>
>> v1 can be found here: https://sourceware.org/ml/gdb-patches/2016-11/msg00813.html
>>
>> ---
>>
>> I was going to go with a single patch for this, but i kept hitting other
>> cases where i needed to adjust the regular expressions and substitution rules.
>>
>> I then decided to have a series with each individual piece that should make it
>> easier to review as well. The changes are all pretty mechanical, but it would
>> be nice to have another pair of eyes looking at these to make sure nothing
>> incorrect got through.
>>
>> The first patch handles the "testfile as test name" problem. The rest of the
>> series handles test names starting with uppercase.
>
> Thanks for the patch, Luis! It would be awesome to also have unique
> names for each testcase, but I realize this is a much more difficult
> task :-).
I have a few ideas and i may submit a RFC to discuss improvements on
this soon.
>
> Just a heads up for everyone: when this patch series is pushed, we are
> probably going to see a lot of known XFAILs return on the BuildBot
> reports. This is due to the way we identify the XFAILs, using their
> whole name in a case-sensitive manner.
>
> The new XFAILs will be detected during the weekend, when the racy tests
> run.
>
> Thanks,
>
Nothing like breaking a lot of tests for a change! :-P
Thanks for the heads up.
prev parent reply other threads:[~2016-11-28 19:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 20:54 Luis Machado
2016-11-25 20:54 ` [PATCH v2 6/8] Fix test names starting with uppercase using multi-line gdb_test_no_output Luis Machado
2016-11-30 20:12 ` Pedro Alves
2016-11-25 20:54 ` [PATCH v2 7/8] Fix test names starting with uppercase using multi-line gdb_test_multiple Luis Machado
2016-11-30 20:47 ` Pedro Alves
2016-11-30 21:05 ` Luis Machado
2016-11-30 22:14 ` Pedro Alves
2016-11-25 20:54 ` [PATCH v2 3/8] Fix test names starting with uppercase using gdb_test_no_output Luis Machado
2016-11-27 16:58 ` Yao Qi
2016-11-25 20:55 ` [PATCH v2 4/8] Fix test names starting with uppercase using gdb_test_multiple Luis Machado
2016-11-27 17:10 ` Yao Qi
2016-11-28 16:06 ` Luis Machado
2016-11-29 14:49 ` Yao Qi
2016-11-29 15:07 ` Luis Machado
2016-11-29 20:55 ` Yao Qi
2016-11-29 21:14 ` Luis Machado
2016-11-30 19:56 ` Pedro Alves
2016-11-25 20:55 ` [PATCH v2 2/8] Fix test names starting with uppercase using gdb_test on a single line Luis Machado
2016-11-27 16:48 ` Yao Qi
2016-11-28 18:13 ` [PATCH v3 " Luis Machado
2016-11-25 20:55 ` [PATCH v2 1/8] Fix test names starting with uppercase output by basic functions Luis Machado
2016-11-29 21:37 ` Yao Qi
2016-11-25 20:55 ` [PATCH v2 8/8] Fixup testcases outputting own name as a test name and standardize failed compilation messages Luis Machado
2016-12-01 11:08 ` Pedro Alves
2016-12-01 13:15 ` Luis Machado
2016-12-01 17:20 ` [PATCH v3 " Luis Machado
2016-12-01 17:35 ` Pedro Alves
2016-12-01 20:52 ` Luis Machado
2016-11-25 20:55 ` [PATCH v2 5/8] Fix test names starting with uppercase using multi-line gdb_test/mi_gdb_test Luis Machado
2016-11-30 20:11 ` Pedro Alves
2016-11-30 20:25 ` Luis Machado
2016-11-28 18:57 ` [PATCH v2 0/8] Fix gdb's testsuite test names Sergio Durigan Junior
2016-11-28 19:00 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=753fb1b5-93a0-4557-329e-aa3f39d3e0c9@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox