From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94798 invoked by alias); 28 Nov 2016 19:00:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94784 invoked by uid 89); 28 Nov 2016 19:00:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=junior, Junior, organization, eyes X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Nov 2016 19:00:37 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cBRAJ-0007hG-T7 from Luis_Gustavo@mentor.com ; Mon, 28 Nov 2016 11:00:35 -0800 Received: from [172.30.6.41] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 28 Nov 2016 11:00:33 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v2 0/8] Fix gdb's testsuite test names References: <1480107244-1484-1-git-send-email-lgustavo@codesourcery.com> <87wpfn8mbd.fsf@redhat.com> To: Sergio Durigan Junior CC: From: Luis Machado Message-ID: <753fb1b5-93a0-4557-329e-aa3f39d3e0c9@codesourcery.com> Date: Mon, 28 Nov 2016 19:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87wpfn8mbd.fsf@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00923.txt.bz2 On 11/28/2016 12:57 PM, Sergio Durigan Junior wrote: > On Friday, November 25 2016, Luis Machado wrote: > >> Changes in v2: >> >> * Patch 1/8 in v1 is now patch 8/8 in v2, due to organization issues. Patch 8/8 >> does a few additional things in v2. Patches 2~8 in v1 are now 1~7 in v2. >> >> Patch 1/8 and Patch 2/8 >> ========= >> >> * Fixed spurious whitespaces. >> >> Patch 8/8 >> ========= >> >> * Updated compilation failure message and replaced existing ones to keep them >> standard. >> >> All other patches have no meaningful changes. >> >> v1 can be found here: https://sourceware.org/ml/gdb-patches/2016-11/msg00813.html >> >> --- >> >> I was going to go with a single patch for this, but i kept hitting other >> cases where i needed to adjust the regular expressions and substitution rules. >> >> I then decided to have a series with each individual piece that should make it >> easier to review as well. The changes are all pretty mechanical, but it would >> be nice to have another pair of eyes looking at these to make sure nothing >> incorrect got through. >> >> The first patch handles the "testfile as test name" problem. The rest of the >> series handles test names starting with uppercase. > > Thanks for the patch, Luis! It would be awesome to also have unique > names for each testcase, but I realize this is a much more difficult > task :-). I have a few ideas and i may submit a RFC to discuss improvements on this soon. > > Just a heads up for everyone: when this patch series is pushed, we are > probably going to see a lot of known XFAILs return on the BuildBot > reports. This is due to the way we identify the XFAILs, using their > whole name in a case-sensitive manner. > > The new XFAILs will be detected during the weekend, when the racy tests > run. > > Thanks, > Nothing like breaking a lot of tests for a change! :-P Thanks for the heads up.