From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA] Change objfile to use new/delete
Date: Thu, 12 Oct 2017 21:42:00 -0000 [thread overview]
Message-ID: <750e68ac-4d0f-74ec-00e4-4a5767b80eeb@ericsson.com> (raw)
In-Reply-To: <20171012181913.4585-1-tom@tromey.com>
On 2017-10-12 02:19 PM, Tom Tromey wrote:
> This changes objfiles to use new and delete rather than xmalloc and
> free. Simon noticed that it uses a non-POD and so shouldn't be
> allocated with XCNEW; and I wanted to be able to use another non-POD as
> a member; this patch is the result.
>
> Regression tested by the buildbot.
This LGTM, just one formatting nit.
> @@ -277,11 +277,16 @@ struct objfile_per_bfd_storage
>
> struct objfile
> {
> + objfile (bfd *, const char *name, objfile_flags);
Let's try to be consistent in one prototype, either include the parameter
names or not.
Thanks,
Simon
prev parent reply other threads:[~2017-10-12 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 18:19 Tom Tromey
2017-10-12 21:42 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=750e68ac-4d0f-74ec-00e4-4a5767b80eeb@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox