From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113290 invoked by alias); 12 Oct 2017 21:42:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112525 invoked by uid 89); 12 Oct 2017 21:42:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Hx-languages-length:647 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Oct 2017 21:42:02 +0000 Received: from ESESSHC011.ericsson.se (Unknown_Domain [153.88.183.51]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id EC.3A.07039.7A1EFD95; Thu, 12 Oct 2017 23:42:00 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.51) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 12 Oct 2017 23:41:59 +0200 Received: from [142.133.61.67] (192.75.88.130) by AMSPR07MB311.eurprd07.prod.outlook.com (2a01:111:e400:802f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Thu, 12 Oct 2017 21:41:57 +0000 Subject: Re: [RFA] Change objfile to use new/delete To: Tom Tromey , References: <20171012181913.4585-1-tom@tromey.com> From: Simon Marchi Message-ID: <750e68ac-4d0f-74ec-00e4-4a5767b80eeb@ericsson.com> Date: Thu, 12 Oct 2017 21:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171012181913.4585-1-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR2001CA0020.namprd20.prod.outlook.com (2603:10b6:404:b4::30) To AMSPR07MB311.eurprd07.prod.outlook.com (2a01:111:e400:802f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 371805f1-fa3c-4c4d-8ba2-08d511ba105c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AMSPR07MB311; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;3:dhrwz9yQ4fJMTOAKDDI+pCg7ZX37hAQ6egD031E96pyqO6QAJSdwKpeg/rh2ULFhw5LOl9UHMHLnGQiY7I4Zcpa4tiqIQOhQ2rPi8FvPnLT56FskZ7ThE6201nBOTWluaR3kHf5hJlC+6jUpkMB0v3xvTrg6xJpoILsxpAE4abnleChdFBt1meLNkcFmPtdY9835RKv8ZRKgMQmmEaUTXKuVYeMd6aXIr5JP0Ijr/bCTC6apVqcDCZiEYP3RsNTK;25:0G3ZocoDBTZ7MtXGhfWaeeVbeH8cXyuhmo0d2YbH7zR0pDAZGatELsjkmfgUPlygO3jFtQWqa0CltK9KRL+5EWXlSiZdfUKKMQwlKLk+Yrjfx5WA9PXgbRV+hr1+JIiqZ3gD3oNfql3HByjBoVsZN/N2n14bnceb7R/TLPx4nz3hGTbNTFH/w2KyxaSF9GC845HeeFfU2xNxFW6avdo6dwzsMGew5R4wzInN9CGgMuE8XJOOEUkDVJsR49zqItEnNJlAxlkql9Qr9PFB+alaBuCoszU2kA7deYHYLEEWnuowy0Q0ubDtJUpkSdcpmLoCjgeOQldOfJedp19rtiJ1wqnSJQ8MKU+Wz/SOg4/oVkY=;31:/dUPtLuedCKLa+JolQxNQmLDYvIE6uKTIYzhOPLQN2epGSE0PLj+y7XURntyWRmcLOkNsLGTbABFWCiKlTgHYr/q1UtZv/JjlGPav9PYIq99OTQUpDuzyUlqb5jzb7bqPiu4YI3jW+v9IU6k07MpSZlXRCkjOQA0T7TdLtmh89+JjyxuZ6qWNR2YGpXetZ1ishQUszGL2wAl/ONP7hNzgMRSahE1ICMSmY46KLvIJeI= X-MS-TrafficTypeDiagnostic: AMSPR07MB311: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;20:Rdqwl+vweByem0kZqkCOKYbUxg9qN09XbsyWv+c/s9ACwYdj0fmYls1BQyVVnmYl2axWCPkv8dwlt5zUjfxgDAsKlIfGd4hUrMQDuoAZAvKvCdh+XJSGbcs/GkEovLb/6UIlHAEO2KbUuXsCDc83EeDKjnn/QQZo+st4FtHpld9MjkCfqZvY687dFPBUhGz9M62Gks5axA9kiOZuOB+TKiUBSWPvNPwd6Vn5rDn5ItSBmUorqmhIw+jefMFtzSmBv6jfdn9k0AaGGsoLggXtGEoeQGTkPkDokAI8GWMbCH9E0EG+o/mtsYb5dAnF7LA98eRUYdPhNx1XcgPZeus3riX7inR88c3QV7UztVU6PvKHTEVrlXT84QU8K8ZeYJKcLqQOju+JkgdXfojCTaBdSrhTAGsp45imbGT4a7d6rc+B9rT9Io2CdYCWEAprdBnyJBuCteGimNUD0X+mAQTnXduIwT9PRyi/P4ehVJCLoyw3aVDnZRAVtxSaOUwV71e/;4:DNX0mENmxqqQwwSko22wr4+UgqUHwwmUXNKKaZT9hHruZcctQTCndcZHcArVvQyYn7xIXhPcKBzVLYvFQkjqS1tLc9jTvfl3A2dptGK0FEIb0whKR/Doh8L+iJj/CcrhOZqQ3nFWKB1DQvDIcKV42E79GslfSZRKxwruR7Nov7pENmRto8mOifJCYoygMTx0SKUSEUoX0kr4LNN4r+TaDxgFjyn04DVkMzm3kRs0CThuyBjrM7g0x1jN92fV9mHc X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB311;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB311; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(346002)(39860400002)(189002)(377454003)(24454002)(377424004)(199003)(53936002)(229853002)(97736004)(68736007)(305945005)(65826007)(25786009)(2950100002)(316002)(3846002)(5660300001)(64126003)(16576012)(83506001)(7736002)(6666003)(4001150100001)(58126008)(105586002)(6116002)(50466002)(65806001)(65956001)(31686004)(101416001)(53546010)(2906002)(66066001)(81166006)(230700001)(478600001)(36756003)(106356001)(49976008)(33646002)(47776003)(6486002)(31696002)(8676002)(8936002)(81156014)(16526018)(50986999)(86362001)(76176999)(23676002)(54356999)(189998001)(6246003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB311;H:[142.133.61.67];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTE7MjM6b0JscHVKdmdoMHBneS9JVDBUcmxhanBLbVpN?= =?utf-8?B?TjJkOGhmWkVVbVB2ZCtwL1RaK2JtQTNiKy9UaStMOGFUR3p3dEhSclZBUlBU?= =?utf-8?B?NG5KaExzcTlZTll3YjBTWWdFbHFVRDNBUHA2NXk0eXJQN0RSMVJNTzc2Ulhx?= =?utf-8?B?SlZjMHhQVU1iOUpIU0k1Q0dFZUUwZ3VJeG9lMkxhckFWTW9Rd2FFVFV0UmdN?= =?utf-8?B?VURRM1Q2VXBmbzZ6N0F1VTJvNmdIa3B1NkJaZWpRa3dVeEhKcVhha2NBL2pF?= =?utf-8?B?QndWVXRoWmpaZ0xtWXFnZVdCZCtOTDdpcUlLT3lMSGtPTVVrOVZqVUFLYisy?= =?utf-8?B?OWVCdHMxd3k4RElCTVk4ekVnbGt2enR5ME9HcHp1WjEwaTVsVmxJSm9GSmZQ?= =?utf-8?B?WTd1S1NkeVRzKzM1NkZBcHRNNmpML3J6T1krRmdIKy9PVkhFYVQ0SUVrWjAw?= =?utf-8?B?Mkw4ZzgvRUdKQTRaQUVUK25sTVFjcW1WUCtOOHF3SFpkRnZSdWRTdTg4Vm1F?= =?utf-8?B?dXhQL0IvSE1oTjY3QktFMXNIYXJ0NTFVQjFsQ3Jya1hNam1vL0ZlTjNVMXd0?= =?utf-8?B?S0t1bWVHb1ZNcThoNGluMlR5bURMWnRwSEw5aTNsSGJFL0NyRFdvL2lUWlFR?= =?utf-8?B?ZjBrVzVEYlBvTnp5aGtPQnovMVVTM0ZlbzhDRVB1Q1NDZlY2L21TQ0JEUXpm?= =?utf-8?B?dUJnbWtoZnRhNDhjaExuNEVXSFlmZDFtYkdsM1ZiK2pxWmFOL25naW9HWjNH?= =?utf-8?B?RGdCTktLSHNndnJ3VW9XSTZIR3E2YWthd0lxTzc5MW10aW9CTGVIdzZMMXJD?= =?utf-8?B?dXNVN05aamJRdU11UDF0TDh5dlZ1VXc4bncybWR3Zi9KdmJiZXR0SzcwcTk4?= =?utf-8?B?cW5zOWE0bzc3UGFLckRiSUVPVWJnNGM5cE9nNmg1clJ6UEwwR1hXK0MvSVJS?= =?utf-8?B?WVk2REFlYk01OXdtV25oNkp3dnpIcWxKZm5OaU8xOGdFaXBIQ0haN2VISVZY?= =?utf-8?B?T241RVl0amMwaUZyeXp4UUVwNzRONWttZ3YwN20reC9IcW4zZXNaM3cvaGQy?= =?utf-8?B?TjRpbTRtZ0pyNkU3S0xWbGZYbFNxVWRrK1VxOWhVYUNBeCtuSCtJWjV2SDRW?= =?utf-8?B?RHl1KzRTQTAxQksrWVBlN1lyQjloMUQzalNEbFRlRE5xS3JYdWJxTDlybDJw?= =?utf-8?B?NS9rMVFBL3hRRlYrWW5NTFhpM2d5dXVmdzJkN04ra2t1dVE2bEc5MGZjQ3hF?= =?utf-8?B?TXlOOHZmOWc3U0wyVGJTWjJDVTdsWjNWYmtnUUFlUlBXd0RxMzA3dmk0OWRJ?= =?utf-8?B?MnpmU3RjVEdrRmQzTytaY2xKSDhSQ1Yxd3p1eE1KaGhFMlgrWUpubkd1RXZr?= =?utf-8?B?dHhseDVkV0xlRHpHbVQ3c1FuUlhYM1pXUGdmN05KQTB0NE53Nkd3QkZ2UVk0?= =?utf-8?B?SDNPaHFtZnA2Zm5adWN3a25pT1p0NUxhc1dyampQby9RdGVTUjBhdzNrK1Iz?= =?utf-8?B?amMrdHc2L2k2ZmNsVTZOcng5Znh2Z0h3REhIZExxczNjWlEyY0hUOUpSWkpn?= =?utf-8?B?bDdWZk9OS0p3RkNMRWpMZkFWeG5zRitVKzFhUU1rOUptVEhoM2xVWUROcXRV?= =?utf-8?B?cG11MngrQ2gwSUVObFBsUjdIeXlxbVBBeHkzSzhkclJXYzhBTFFtY2xub0N6?= =?utf-8?B?d2Z5cDhlZGIrblIvblBaMytQZDBLdmlpbTFyTU83cllBeFNzV2dTcHVxWU9r?= =?utf-8?B?WEdoQVpqVm1mY1VhR2htRHg3Q1d3MlVNVjQxYjRLSkJhK2xlQzRoa0pkSERx?= =?utf-8?B?QURyRi81M2p3MitrNUp1eGlRRzhTV0grR0x3b0UzQ0x6M0xHVytzR0h6ZzB4?= =?utf-8?Q?jzybsg5qQBFLxrlitaisD0FUTt23MDR?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB311;6:hXHhKwpDy4MUTcdndwK8B5KV/cPCxCfLHi1lJADDKUU3H408LjMZsz4F9aIaEdL0mq/8OiW8OO5KTrDuzNhXxIlic+UjxiLy+Km2+byegiEL0hlNJL02g/4oKtlcClCIqP7RJODhHJ+i4e7bt/1HqQx1ZAgCTFfjPKp2CIOZNHHsUGn5zdiepcom/H3B3qkiGWupVJu3vkmk/mmcvlR1uHLAN1daHZ98CnRLroN1EjoSeBVm95ilP8JU+oArLygKo+3bJV0AVCMsK37i6AzVKnfSKQJcAHEnBYUmEZ04oYvsBa1dy0BrsUdTm+Nk9q6ohSChnmURjK2BHQebJ1OJ0w==;5:JedDJvlVIcYZwiaZeLxkeU96su+Xc6o00Ba9r2oiiAVhV2WLCi0NmklmT0veCdrFQYS/AY56ReFp7AenUPnwyV9TrCWFGUYuCVSZcor6KqiLM+s1xS2p7D+xBvY/2qWcD+aI2BOyKOwVGyZUqfCCBAWhBn0+rw7qumD6AVAErQ4=;24:Y3N+rT8SZeY5HJzfKQwpWjp3VXeRo8eIYlmi+HD/kpSAp+XW90/50sCkUR7EdBiqRYepI+Eyov86SQmgb6ttS1TKJYLGaSnksTE5B3hrHcE=;7:WtRILJRuFhCwqK1P4RFV2mBhQcsx9OR5rrcVCgxTzKEJDwIeU6ovn968Pex325QModn4d9p0803atQ5fAzWULtncg44FR7U2zOiut8edvfomSQTpvqf9XxKpfx1E7u/TZtB/CjgKvqgVjkqGcdHcZbVIg9Vs2cLAeKFslRELwd2W/+DCaiC9Tbneg0Oop31vS9XPayhDtKgLaI2/IQetQXXkjGWoz1VFkuKBdSzAESc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 21:41:57.3257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB311 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00329.txt.bz2 On 2017-10-12 02:19 PM, Tom Tromey wrote: > This changes objfiles to use new and delete rather than xmalloc and > free. Simon noticed that it uses a non-POD and so shouldn't be > allocated with XCNEW; and I wanted to be able to use another non-POD as > a member; this patch is the result. > > Regression tested by the buildbot. This LGTM, just one formatting nit. > @@ -277,11 +277,16 @@ struct objfile_per_bfd_storage > > struct objfile > { > + objfile (bfd *, const char *name, objfile_flags); Let's try to be consistent in one prototype, either include the parameter names or not. Thanks, Simon